linux-kernel - Re: [PATCH] KVM: selftests: arm64: Correct feature test for S1PIE in get-reg-list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7b9b3ef4-66da-4314-8265-5947998758e9@sirena.org.uk>
Date: Fri, 2 Aug 2024 13:43:03 +0100
From: Mark Brown <broonie@...nel.org>
To: Marc Zyngier <maz@...nel.org>
Cc: Oliver Upton <oliver.upton@...ux.dev>,
	James Morse <james.morse@....com>,
	Suzuki K Poulose <suzuki.poulose@....com>,
	Paolo Bonzini <pbonzini@...hat.com>, Shuah Khan <shuah@...nel.org>,
	Catalin Marinas <catalin.marinas@....com>,
	Joey Gouly <joey.gouly@....com>,
	linux-arm-kernel@...ts.infradead.org, kvmarm@...ts.linux.dev,
	kvm@...r.kernel.org, linux-kselftest@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] KVM: selftests: arm64: Correct feature test for S1PIE in
 get-reg-list

On Fri, Aug 02, 2024 at 10:00:28AM +0100, Marc Zyngier wrote:

> Also, the test predates the generated stuff by some margin.

Yeah, there were still defines in the main kernel source that were being
retyped rather than shared previously which made me wonder.

> Mark Brown <broonie@...nel.org> wrote:

> > I'd certainly be happy to convert, though that does
> > seem a bit invasive for a fix.

> Not for a point fix, for sure. And if you do, make sure it is entirely
> scripted.

When you say "entirely scripted" here I take it you're referring to the
list of registers as well, and I guess also to the information about
what is enumerated by which ID register values?  I'd already been
thinking about looking at the latter bit, and possibly also tracking
wiring things up to traps (though that's only relevant inside the
kernel).  I agree that seems sensible, but I do think we can usefully do
things in stages - even just replacing the magic numbers with use of the
defines would be less error prone.  It would be great if we just
automatically covered every sysreg we know about in this test without
any manual steps.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)