linux-kernel - Re: [PATCH v3 0/2] Use sysfs_emit() and sysfs_emit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJZ5v0gCSiQaPQD05w-QKQiNuWeh14XAVfx3=MGi24j3XjV6Mg@mail.gmail.com>
Date: Fri, 2 Aug 2024 16:05:23 +0200
From: "Rafael J. Wysocki" <rafael@...nel.org>
To: Xueqin Luo <luoxueqin@...inos.cn>
Cc: rafael@...nel.org, pavel@....cz, len.brown@...el.com, 
	linux-pm@...r.kernel.org, xiongxin@...inos.cn, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 0/2] Use sysfs_emit() and sysfs_emit_at() in "show" functions

On Thu, Aug 1, 2024 at 10:32 AM Xueqin Luo <luoxueqin@...inos.cn> wrote:
>
> As Documentation/filesystems/sysfs.rst suggested,
> show() should only use sysfs_emit() or sysfs_emit_at() when formatting
> the value to be returned to user space.
>
> No functional change intended.
>
> v3: Changed code style as suggested by Rafael J. Wysockid, thanks!
>
> v2: Adopted Christophe's suggestions as follows:
> - Fixed some formatting
> - Fixed logic errors in mem_sleep_show, pm_test_show, state_show functions
> Thanks!
>
> Xueqin Luo (2):
>   PM: hibernate: Use sysfs_emit() and sysfs_emit_at() in "show"
>     functions
>   PM: Use sysfs_emit() and sysfs_emit_at() in "show" functions
>
>  kernel/power/hibernate.c | 22 +++++------
>  kernel/power/main.c      | 82 ++++++++++++++++++++++------------------
>  2 files changed, 56 insertions(+), 48 deletions(-)
>
> --

Both patches applied as 6.12 material, thanks!