linux-kernel - Re: [PATCH 1/1] arm64: dts: imx93: add lpi2c1 and child node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zqztwh3yghN8Drnj@lizhi-Precision-Tower-5810>
Date: Fri, 2 Aug 2024 10:31:30 -0400
From: Frank Li <Frank.li@....com>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, Shawn Guo <shawnguo@...nel.org>,
	Sascha Hauer <s.hauer@...gutronix.de>,
	Pengutronix Kernel Team <kernel@...gutronix.de>,
	Fabio Estevam <festevam@...il.com>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@...r.kernel.org>,
	"open list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" <imx@...ts.linux.dev>,
	"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" <linux-arm-kernel@...ts.infradead.org>,
	open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/1] arm64: dts: imx93: add lpi2c1 and child node

On Fri, Aug 02, 2024 at 09:25:54AM +0200, Krzysztof Kozlowski wrote:
> On 01/08/2024 18:09, Frank Li wrote:
> > From: Clark Wang <xiaoning.wang@....com>
> >
> > Add lpi2c1 and child node for imx93-11x11-evk board.
>
> Why? What for? What are these? We see all this from the diff, so commit
> msg should explain why and what do you want to achieve.

I really don't know how to explain why/what for these straing forward
thing, hardware board has such component, just add it dts file.

>
> >
> > Signed-off-by: Clark Wang <xiaoning.wang@....com>
> > Reviewed-by: Haibo Chen <haibo.chen@....com>
> > Signed-off-by: Li Yang <leoyang.li@....com>
> > Signed-off-by: Dong Aisheng <aisheng.dong@....com>
> > Signed-off-by: Frank Li <Frank.Li@....com>
> > ---
> >  .../boot/dts/freescale/imx93-11x11-evk.dts    | 21 +++++++++++++++++++
> >  1 file changed, 21 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts b/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts
> > index a15987f49e8d6..dd387b820831a 100644
> > --- a/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts
> > +++ b/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts
> > @@ -145,6 +145,20 @@ ethphy2: ethernet-phy@2 {
> >  	};
> >  };
> >
> > +&lpi2c1 {
> > +	#address-cells = <1>;
> > +	#size-cells = <0>;
> > +	clock-frequency = <400000>;
> > +	pinctrl-names = "default";
> > +	pinctrl-0 = <&pinctrl_lpi2c1>;
> > +	status = "okay";
> > +
> > +	lsm6dsm@6a {
>
> Node names should be generic. See also an explanation and list of
> examples (not exhaustive) in DT specification:
> https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation

I really sorry, I forget it again.
Frank

>
>
>
>
> Best regards,
> Krzysztof
>