linux-kernel - Re: question on [uprobes] special vma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CABi2SkXqkC3wX4wnhXTXrLSs-6PLO-Fj4g=Hcvqq=ppv4QWUzA@mail.gmail.com>
Date: Fri, 2 Aug 2024 07:59:09 -0700
From: Jeff Xu <jeffxu@...omium.org>
To: Oleg Nesterov <oleg@...hat.com>
Cc: Kees Cook <keescook@...omium.org>, srikar@...ux.vnet.ibm.com, 
	Ryan Roberts <ryan.roberts@....com>, "adrian.hunter@...el.com" <adrian.hunter@...el.com>, 
	"glider@...gle.com" <glider@...gle.com>, Matthew Wilcox <willy@...radead.org>, zokeefe@...gle.com, 
	hughd@...gle.com, luto@...capital.net, 
	"jmarchan@...hat.com" <jmarchan@...hat.com>, "rientjes@...gle.com" <rientjes@...gle.com>, 
	Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar <mingo@...nel.org>, 
	LKML <linux-kernel@...r.kernel.org>, linux-mm@...ck.org, 
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: question on [uprobes] special vma

Hi Oleg

On Fri, Aug 2, 2024 at 2:00 AM Oleg Nesterov <oleg@...hat.com> wrote:
>
> Hi Jeff,
>
> On 08/01, Jeff Xu wrote:
> >
> > __create_xol_area() calls  _install_special_mapping() to create a vma
> > named [uprobes].
> >
> > I'm trying to find out the lifetime of this uprobes vma, e.g. when it
> > is created, will it ever be unmapped/remapped/changed during the
> > lifetime of the process.
> >
> > If  the uprobes vma remains the same during the lifetime of the
> > process,
>
> Yes,
>
That is nice.

> > I can call mseal on it so user space can't change it, i.e.
> > blocking munmap/mremap/mprotect/mmap, etc.
>
> I didn't even know about mm/mseal.c...
>
The TLDR: once the memory area is sealed,
mmap/munmap/mremap/mprotect/some of madvise will be blocked.

https://docs.kernel.org/userspace-api/mseal.html

On a related topic, Adhemerval Zanella has an RFC adding mseal support
for dynamic linker.

https://public-inbox.org/libc-alpha/20240731200307.2269811-1-adhemerval.zanella@linaro.org/

> at first glance do_mseal() just adds VM_SEALED for can_modify_vma().
>
> So it seems that xol_add_vma() can just pass the additional VM_SEALED
> flag to _install_special_mapping(), no?
>
Yes. Before I make that change, I want to confirm that [uprobes] VMA
is immutable during the lifetime of the process, hence this email.

> But why it depends on CONFIG_64_BIT?
>
It needn't, but the vm_flags_t in the vma struct for 32 bit is full,
adding 32 bit support will make split/merge code more complex, (at one
point of RFC process, 32 bit is included but later removed),

If we like to have 32 bit support, perhaps we need to refactor the mm
code to expand vm_flags first.

Thanks for your help !
-Jeff

> Oleg.
>