linux-kernel - RE: [PATCH] Drivers: hv: vmbus: Fix the misplaced function description

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <SN6PR02MB41578B75E804B59A2B8A8E24D4B32@SN6PR02MB4157.namprd02.prod.outlook.com>
Date: Fri, 2 Aug 2024 15:51:37 +0000
From: Michael Kelley <mhklinux@...look.com>
To: Roman Kisel <romank@...ux.microsoft.com>, "kys@...rosoft.com"
	<kys@...rosoft.com>, "haiyangz@...rosoft.com" <haiyangz@...rosoft.com>,
	"wei.liu@...nel.org" <wei.liu@...nel.org>, "decui@...rosoft.com"
	<decui@...rosoft.com>, "sashal@...nel.org" <sashal@...nel.org>,
	"linux-hyperv@...r.kernel.org" <linux-hyperv@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC: "apais@...rosoft.com" <apais@...rosoft.com>, "benhill@...rosoft.com"
	<benhill@...rosoft.com>, "ssengar@...rosoft.com" <ssengar@...rosoft.com>,
	"sunilmut@...rosoft.com" <sunilmut@...rosoft.com>, "vdso@...bites.dev"
	<vdso@...bites.dev>
Subject: RE: [PATCH] Drivers: hv: vmbus: Fix the misplaced function
 description

From: Roman Kisel <romank@...ux.microsoft.com> Sent: Thursday, August 1, 2024 2:23 PM
> 
> When hv_synic_disable_regs was introduced, it received the description
> of hv_synic_cleanup. Fix that.
> 
> Fixes: dba61cda3046 ("Drivers: hv: vmbus: Break out synic enable and disable
> operations")
> 
> Signed-off-by: Roman Kisel <romank@...ux.microsoft.com>
> ---
>  drivers/hv/hv.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/hv/hv.c b/drivers/hv/hv.c
> index e0d676c74f14..36d9ba097ff5 100644
> --- a/drivers/hv/hv.c
> +++ b/drivers/hv/hv.c
> @@ -342,9 +342,6 @@ int hv_synic_init(unsigned int cpu)
>  	return 0;
>  }
> 
> -/*
> - * hv_synic_cleanup - Cleanup routine for hv_synic_init().
> - */
>  void hv_synic_disable_regs(unsigned int cpu)
>  {
>  	struct hv_per_cpu_context *hv_cpu =
> @@ -436,6 +433,9 @@ static bool hv_synic_event_pending(void)
>  	return pending;
>  }
> 
> +/*
> + * hv_synic_cleanup - Cleanup routine for hv_synic_init().
> + */
>  int hv_synic_cleanup(unsigned int cpu)
>  {
>  	struct vmbus_channel *channel, *sc;
> 
> base-commit: 831bcbcead6668ebf20b64fdb27518f1362ace3a
> --
> 2.34.1
> 

Reviewed-by: Michael Kelley <mhkelley@...look.com>