linux-kernel - Re: [PATCH V3 0/2] uapi: Add support for GENMASK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1781c39a-2280-49ed-aaaa-b1684744615e@arm.com>
Date: Fri, 2 Aug 2024 07:00:43 +0530
From: Anshuman Khandual <anshuman.khandual@....com>
To: Yury Norov <yury.norov@...il.com>
Cc: linux-kernel@...r.kernel.org, ardb@...nel.org,
 Andrew Morton <akpm@...ux-foundation.org>,
 Rasmus Villemoes <linux@...musvillemoes.dk>, Arnd Bergmann <arnd@...db.de>,
 linux-arch@...r.kernel.org
Subject: Re: [PATCH V3 0/2] uapi: Add support for GENMASK_U128()



On 8/1/24 20:13, Yury Norov wrote:
> On Thu, Aug 1, 2024 at 12:16 AM Anshuman Khandual
> <anshuman.khandual@....com> wrote:
>>
>> This adds support for GENMASK_U128() and some corresponding tests as well.
>> GENMASK_U128() generated 128 bit masks will be required later on the arm64
>> platform for enabling FEAT_SYSREG128 and FEAT_D128 features.
>>
>> Because GENMAKS_U128() depends on __int128 data type being supported in the
>> compiler, its usage needs to be protected with CONFIG_ARCH_SUPPORTS_INT128.
>>
>> Cc: Andrew Morton <akpm@...ux-foundation.org>
>> Cc: Yury Norov <yury.norov@...il.com>
>> Cc: Rasmus Villemoes <linux@...musvillemoes.dk>
>> Cc: Arnd Bergmann <arnd@...db.de>>
>> Cc: linux-kernel@...r.kernel.org
>> Cc: linux-arch@...r.kernel.org
> 
> For the patches:
> 
> Reviewed-by: Yury Norov <yury.norov@...il.com>

Thanks Yury.

> 
> This series doesn't include a real use-case for the new macros. Do you
> have some?
> I can take it via my branch, but I need at least one use-case to not
> merge dead code.

I have recently posted the following patch for arm64 platform although
most of the subsequent work is still in progress. But for now there
are some corresponding tests for this new GENMASK_U128() ABI as well.
Hence it will be really great to have these two patches merged first.
Thank you.

https://lore.kernel.org/all/20240801054436.612024-1-anshuman.khandual@arm.com/