linux-kernel - Re: [herbertx/cryptodev] crypto: arm64/poly1305

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zq18V66ufraB_1-T@gondor.apana.org.au>
Date: Sat, 3 Aug 2024 08:39:51 +0800
From: Herbert Xu <herbert@...dor.apana.org.au>
To: herbertx/cryptodev <reply+AAIFISMST74UQEQBJUWW7J6EXDLZNEVBMPHARJBRSY@...ly.github.com>
Cc: herbertx/cryptodev <cryptodev@...eply.github.com>,
	Author <author@...eply.github.com>, Jia He <justin.he@....com>,
	"David S. Miller" <davem@...emloft.net>,
	Catalin Marinas <catalin.marinas@....com>,
	linux-crypto@...r.kernel.org, Will Deacon <will@...nel.org>,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	Ard Biesheuvel <ardb@...nel.org>,
	Andy Polyakov <appro@...ptogams.org>
Subject: Re: [herbertx/cryptodev] crypto: arm64/poly1305 - move data to
 rodata section (47d9625)

On Fri, Aug 02, 2024 at 08:09:10AM -0700, Andy Polyakov wrote:
> Formally speaking this is error prone, because there is no guarantee that linker will be able to resolve it as argument to `adr` instruction above. I mean since the address is resolved with `adr` instruction alone, there is a limit on how far the label can be from the instruction in question. On a practical level, if/since it's compiled as part of a kernel module, it won't be a problem, because the module won't be large enough to break the limit, but it **is** a problem in general case.
> 
> But why would objtool attempt to disassemble it? Does it actually attempt to disassemble unreferenced spaces between functions? Note that the .Lzeros label doesn't make it into .o file, so there won't be anything in the symbol table to discover as potential entry point...
> 
> -- 
> Reply to this email directly or view it on GitHub:
> https://github.com/herbertx/cryptodev/commit/47d96252099a7184b4bad852fcfa3c233c1d2f71#r144978326
> You are receiving this because you authored the thread.
> 
> Message ID: <herbertx/cryptodev/commit/47d96252099a7184b4bad852fcfa3c233c1d2f71/144978326@...hub.com>

Adding the original Cc list.
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt