linux-kernel - Re: [PATCH] syscalls: fix syscall macros for newfstat/newfstatat

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zq3jqeq6USL066k+@tucnak>
Date: Sat, 3 Aug 2024 10:00:41 +0200
From: Jakub Jelinek <jakub@...hat.com>
To: Rudi Heitbaum <rudi@...tbaum.com>
Cc: Arnd Bergmann <arnd@...nel.org>, Catalin Marinas <catalin.marinas@....com>,
        Will Deacon <will@...nel.org>, Huacai Chen <chenhuacai@...nel.org>,
        Paul Walmsley <paul.walmsley@...ive.com>,
        Palmer Dabbelt <palmer@...belt.com>, Albert Ou <aou@...s.berkeley.edu>,
        Andreas Schwab <schwab@...e.de>, Florian Weimer <fweimer@...hat.com>,
        linux-riscv@...ts.infradead.org, linux-arm-kernel@...ts.infradead.org,
        linux-api@...r.kernel.org, Arnd Bergmann <arnd@...db.de>,
        WANG Xuerui <kernel@...0n.name>,
        "Masami Hiramatsu (Google)" <mhiramat@...nel.org>,
        linux-kernel@...r.kernel.org, loongarch@...ts.linux.dev
Subject: Re: [PATCH] syscalls: fix syscall macros for newfstat/newfstatat

On Sat, Aug 03, 2024 at 05:14:41AM +0000, Rudi Heitbaum wrote:
> With this patch to kernel 6.11-rc1 the error whilst compiling gcc-14.2 for
> aarch64 with libsanitizer has changed from '__NR_newfstatat' to
> '__NR_fstat', so some change, but still fail8ng.
> 
> sanitizer_syscall_linux_aarch64.inc:13:23: error: '__NR_newfstatat' was not declared in this scope
>    13 | #define SYSCALL(name) __NR_ ## name
>       |                       ^~~~~
> 
> sanitizer_syscall_linux_aarch64.inc:13:23: error: '__NR_fstat' was not declared in this scope
>    13 | #define SYSCALL(name) __NR_ ## name
>       |                       ^~~~~

Probably it would be useful to check
echo '#include <asm/unistd.h>' | gcc -E -dD -xc - | grep '#define __NR_' | sort
for all arches between 6.10 and the latest git, diff them and resolve any
unintended differences.

	Jakub