linux-kernel - Re: [PATCH 07/12] selftests/nolibc: determine $(srctree) first

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240803094024.GD29127@1wt.eu>
Date: Sat, 3 Aug 2024 11:40:24 +0200
From: Willy Tarreau <w@....eu>
To: Thomas Weißschuh <linux@...ssschuh.net>
Cc: Shuah Khan <shuah@...nel.org>, linux-kernel@...r.kernel.org,
        linux-kselftest@...r.kernel.org
Subject: Re: [PATCH 07/12] selftests/nolibc: determine $(srctree) first

On Sun, Jul 28, 2024 at 12:10:01PM +0200, Thomas Weißschuh wrote:
> Avoid needing relative includes.

I'm not opposed, but what's the benefit ? IMHO relative paths are
generally more flexible and robust. you could imagine a completely
made up example in which you have a symlink to selftests/nolibc in
your home dir, which works perfectly with relative paths when you
cd into it while it would not anymore with absolute paths (unless
you use cd -P).

Thus if we are decided to lose that flexibility at least it should
be argumented in the commit message.

Thanks,
Willy