linux-kernel - Re: [PATCH v1] iio: adc: ads1119: Fix IRQ flags

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240803122127.221da36f@jic23-huawei>
Date: Sat, 3 Aug 2024 12:21:27 +0100
From: Jonathan Cameron <jic23@...nel.org>
To: João Paulo Gonçalves
 <jpaulo.silvagoncalves@...il.com>
Cc: Francesco Dolcini <francesco@...cini.it>, Lars-Peter Clausen
 <lars@...afoo.de>, Francesco Dolcini <francesco.dolcini@...adex.com>,
 linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1] iio: adc: ads1119: Fix IRQ flags

On Wed, 31 Jul 2024 11:20:16 -0300
João Paulo Gonçalves <jpaulo.silvagoncalves@...il.com> wrote:

> On Wed, Jul 31, 2024 at 04:06:57PM +0200, Francesco Dolcini wrote:
> > From: Francesco Dolcini <francesco.dolcini@...adex.com>
> > 
> > Remove IRQF_TRIGGER_FALLING flag from irq request, this should come from
> > the platform firmware and should not be hard-coded into the driver.
> > 
> > Add IRQF_ONESHOT flag to the irq request, the interrupt should not be
> > re-activated in interrupt context, it should be done only after the
> > device irq handler run.
> >  
> 
> Reviwed-by: João Paulo Gonçalves <jpaulo.silvagoncalves@...il.com>

For the direction, there is a risk that we will break someone who
has a firmware that isn't setting this correctly.
I don't mind doing that if we have another board that needs control
(and is setting it appropriately) though.  Is that true here, or is
this just cleanup?

If it's cleanup we tend to leave these alone (but not introduce them
into new code!)

Jonathan