[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CANiq72n_v76yMFJwy8S+Akf6T8hOM-JGwP_WUKEdiNvo371NfQ@mail.gmail.com>
Date: Sat, 3 Aug 2024 14:24:21 +0200
From: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To: Benno Lossin <benno.lossin@...ton.me>
Cc: Gary Guo <gary@...yguo.net>, Matt Gilbride <mattgilbride@...gle.com>,
Miguel Ojeda <ojeda@...nel.org>, Alex Gaynor <alex.gaynor@...il.com>,
Wedson Almeida Filho <wedsonaf@...il.com>, Boqun Feng <boqun.feng@...il.com>,
Björn Roy Baron <bjorn3_gh@...tonmail.com>,
Andreas Hindborg <a.hindborg@...sung.com>, Alice Ryhl <aliceryhl@...gle.com>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Arve Hjønnevåg <arve@...roid.com>,
Todd Kjos <tkjos@...roid.com>, Martijn Coenen <maco@...roid.com>,
Joel Fernandes <joel@...lfernandes.org>, Carlos Llamas <cmllamas@...gle.com>,
Suren Baghdasaryan <surenb@...gle.com>, Christian Brauner <brauner@...nel.org>, Rob Landley <rob@...dley.net>,
Davidlohr Bueso <dave@...olabs.net>, Michel Lespinasse <michel@...pinasse.org>,
rust-for-linux@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v6 1/6] rust: kernel: add `drop_contents` to `BoxExt`
On Wed, Jul 31, 2024 at 10:47 PM Benno Lossin <benno.lossin@...ton.me> wrote:
>
> Note that the newest version of this patch can be found at [1]. I agree,
> it should probably take `this: Self` instead of a `self` receiver.
>
> @Miguel, do you think I should send a new version with that change?
You mean with `this` + Boqun's feedback there fixed? Yeah, if you have
a moment, that would be nice. Thanks!
Cheers,
Miguel
Powered by blists - more mailing lists