linux-kernel - Re: [PATCH] bus: ti-sysc: Use of_property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2ff177ed-a5e8-46ad-9902-14f377033da2@kernel.org>
Date: Sat, 3 Aug 2024 17:56:28 +0300
From: Roger Quadros <rogerq@...nel.org>
To: "Rob Herring (Arm)" <robh@...nel.org>,
 Aaro Koskinen <aaro.koskinen@....fi>, Andreas Kemnade
 <andreas@...nade.info>, Kevin Hilman <khilman@...libre.com>,
 Tony Lindgren <tony@...mide.com>
Cc: linux-omap@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] bus: ti-sysc: Use of_property_present()



On 31/07/2024 22:12, Rob Herring (Arm) wrote:
> Use of_property_present() to test for property presence rather than
> of_get_property(). This is part of a larger effort to remove callers
> of of_get_property() and similar functions. of_get_property() leaks
> the DT property data pointer which is a problem for dynamically
> allocated nodes which may be freed.
> 
> The code was also incorrectly assigning the return value to a 'struct
> property' pointer. It didn't matter as "prop" was never dereferenced.
> 
> Signed-off-by: Rob Herring (Arm) <robh@...nel.org>

Reviewed by: Roger Quadros <rogerq@...nel.org>