[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <4637f562f327f7495ccfdd88590e07ef@manjaro.org>
Date: Sat, 03 Aug 2024 17:39:42 +0200
From: Dragan Simic <dsimic@...jaro.org>
To: Sebastian Reichel <sebastian.reichel@...labora.com>
Cc: Lee Jones <lee@...nel.org>, Dmitrii Osipenko
<dmitry.osipenko@...labora.com>, Mark Brown <broonie@...nel.org>, Urja
<urja@...a.dev>, Heiko Stuebner <heiko@...ech.de>,
linux-rockchip@...ts.infradead.org, linux-spi@...r.kernel.org,
linux-kernel@...r.kernel.org, kernel@...labora.com, stable@...r.kernel.org
Subject: Re: [PATCH v1 1/1] mfd: rk8xx: Fix shutdown handler
Hello all,
On 2024-08-01 17:22, Sebastian Reichel wrote:
> On Thu, Aug 01, 2024 at 02:18:23PM GMT, Lee Jones wrote:
>> > + /*
>> > + * Currently the Rockchip SPI driver always sleeps when doing SPI
>> > + * transfers. This is not allowed in the SYS_OFF_MODE_POWER_OFF
>> > + * handler, so we are using the prepare handler as a workaround.
>> > + * This should be removed once the Rockchip SPI driver has been
>> > + * adapted.
>> > + */
>>
>> So why not just adapt the SPI driver now?
>
> This patch is simple and thus can easily be backported, so that the
> Acer Chromebook shutdown is fixed in the stable kernels. SPI based
> rkxx has been using SYS_OFF_MODE_POWER_OFF_PREPARE from the start,
> so it's not a regression.
>
> As far as I could see the SPI framework does not have something
> comparable to the I2C .xfer_atomic handler. So fixing up the
> Rockchip SPI driver probably involves creating some SPI core
> helpers. I'm not yet sure about the best way to deal with this.
> But I guess it will be better not having to backport all of the
> requires changes to stable.
>
> In any case I think the next step in this direction is discussing
> how to handle this in general for SPI.
I agree about accepting this (hot)fix first, and improving the SPI
drivers later. Having this fixed now provides clear benefits.
Also, please feel free to include:
Reviewed-by: Dragan Simic <dsimic@...jaro.org>
>> What's the bet that if accepted, this hack is still here in 5 years
>> time?
>
> Even if I don't work on this now, I would expect somebody to have
> issues with broken shutdown on RK3588 boards before 5 years are
> over :)
Powered by blists - more mailing lists