linux-kernel - Re: [PATCH v1] iio: adc: ads1119: Fix IRQ flags

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240803164805.6929a84d@jic23-huawei>
Date: Sat, 3 Aug 2024 16:48:05 +0100
From: Jonathan Cameron <jic23@...nel.org>
To: Francesco Dolcini <francesco@...cini.it>
Cc: João Paulo Gonçalves
 <jpaulo.silvagoncalves@...il.com>, Lars-Peter Clausen <lars@...afoo.de>,
 Francesco Dolcini <francesco.dolcini@...adex.com>,
 linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1] iio: adc: ads1119: Fix IRQ flags

On Sat, 3 Aug 2024 14:12:52 +0200
Francesco Dolcini <francesco@...cini.it> wrote:

> Hello Jonathan,
> 
> On Sat, Aug 03, 2024 at 12:21:27PM +0100, Jonathan Cameron wrote:
> > On Wed, 31 Jul 2024 11:20:16 -0300
> > João Paulo Gonçalves <jpaulo.silvagoncalves@...il.com> wrote:
> >   
> > > On Wed, Jul 31, 2024 at 04:06:57PM +0200, Francesco Dolcini wrote:  
> > > > From: Francesco Dolcini <francesco.dolcini@...adex.com>
> > > > 
> > > > Remove IRQF_TRIGGER_FALLING flag from irq request, this should come from
> > > > the platform firmware and should not be hard-coded into the driver.
> > > > 
> > > > Add IRQF_ONESHOT flag to the irq request, the interrupt should not be
> > > > re-activated in interrupt context, it should be done only after the
> > > > device irq handler run.
> > > >    
> > > 
> > > Reviwed-by: João Paulo Gonçalves <jpaulo.silvagoncalves@...il.com>  
> > 
> > For the direction, there is a risk that we will break someone who
> > has a firmware that isn't setting this correctly.  
> 
> > I don't mind doing that if we have another board that needs control
> > (and is setting it appropriately) though.  Is that true here, or is
> > this just cleanup?
> > 
> > If it's cleanup we tend to leave these alone (but not introduce them
> > into new code!)  
> 
> The driver was just introduced by me in v6.11, I assume that the only
> user is a board that is not yet available in the upstream Linux kernel
> (we gonna send the DT soon), with that said I am relatively confident we
> are not going to break any user.

ah! I'd missed the timeline detail completely.  Too many drivers and they
all have similar names :)

> 
> The reason for sending this patch is that we just stumbled across
> a different driver that was hard-coding the IRQ flags and it was not working
> for our hardware, at that moment I realized that the decision on the just
> added ti-ads1119 was not the best one.
> 
> The idea of this patch is to clean this up _before_ any user is
> affected.
> 
Excellent.  Applied to the fixes-togreg branch of iio.git.

Thanks,

Jonathan


> Francesco
>