linux-kernel - Re: [PATCH] mm: zswap: make the lock critical section obvious in shrink

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKEwX=N1GZEGnuXo_iW1N9Sx+Jon8=rqe7vznKwL4RQ7t349fA@mail.gmail.com>
Date: Sat, 3 Aug 2024 14:35:55 -0700
From: Nhat Pham <nphamcs@...il.com>
To: Yosry Ahmed <yosryahmed@...gle.com>
Cc: Andrew Morton <akpm@...ux-foundation.org>, Johannes Weiner <hannes@...xchg.org>, 
	Chengming Zhou <chengming.zhou@...ux.dev>, Takero Funaki <flintglass@...il.com>, linux-mm@...ck.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm: zswap: make the lock critical section obvious in shrink_worker()

On Fri, Aug 2, 2024 at 10:33 PM Yosry Ahmed <yosryahmed@...gle.com> wrote:
>
> Move the comments and spin_{lock/unlock}() calls around in
> shrink_worker() to make it obvious the lock is protecting the loop
> updating zswap_next_shrink.
>
> Signed-off-by: Yosry Ahmed <yosryahmed@...gle.com>

Thanks, it looks cleaner to me too.

Reviewed-by: Nhat Pham <nphamcs@...il.com>