linux-kernel - Re: [PATCH] staging: media: atomisp: Add parentheses around macro definitions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87v80i475p.fsf@melete.silentflame.com>
Date: Sat, 03 Aug 2024 11:28:02 +0800
From: Sean Whitton <spwhitton@...hitton.name>
To: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc: ~lkcamp/patches@...ts.sr.ht,  helen.koike@...labora.com,  Hans de Goede
 <hdegoede@...hat.com>,  Mauro Carvalho Chehab <mchehab@...nel.org>,
  Sakari Ailus <sakari.ailus@...ux.intel.com>,
  linux-media@...r.kernel.org,  linux-staging@...ts.linux.dev,
  linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: media: atomisp: Add parentheses around macro
 definitions

Hello,

On Tue 30 Jul 2024 at 08:38am +02, Greg Kroah-Hartman wrote:

> This isn't a "complex values", and really should just be removed
> entirely and use the correct "static inline" properly.

I found that there are several headers in
atomisp/pci/hive_isp_css_include which have this pattern of defining an
_INLINE_*_ preprocessor constant, and using it to choose between
'extern' and 'static inline' in each file where the header is included.

I don't know what the author's intention was.  Are you saying that you
think this preprocessor mechanism should just be replaced with
hardcoding 'extern' or 'static inline' in each file which includes one
of these headers?

Thanks!

-- 
Sean Whitton