linux-kernel - Re: [PATCH 0/6] Update the device tree for Ampere's BMC platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1c2dca43-444d-44a7-b304-5fbd59b788a8@amperemail.onmicrosoft.com>
Date: Sat, 3 Aug 2024 10:49:09 +0700
From: Chanh Nguyen <chanh@...eremail.onmicrosoft.com>
To: "Rob Herring (Arm)" <robh@...nel.org>,
 Chanh Nguyen <chanh@...amperecomputing.com>
Cc: Joel Stanley <joel@....id.au>, Conor Dooley <conor+dt@...nel.org>,
 devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 Open Source Submission <patches@...erecomputing.com>,
 linux-aspeed@...ts.ozlabs.org, Andrew Jeffery <andrew@...id.au>,
 linux-kernel@...r.kernel.org, Thang Nguyen <thang@...amperecomputing.com>,
 Phong Vo <phong@...amperecomputing.com>,
 Quan Nguyen <quan@...amperecomputing.com>,
 OpenBMC Maillist <openbmc@...ts.ozlabs.org>, Rob Herring
 <robh+dt@...nel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>
Subject: Re: [PATCH 0/6] Update the device tree for Ampere's BMC platform



On 01/08/2024 22:29, Rob Herring (Arm) wrote:
> 
> On Thu, 01 Aug 2024 09:12:10 +0000, Chanh Nguyen wrote:
>> Updates the device tree to support some features on Ampere's
>> Mt.Mitchell BMC and Ampere's Mt.Jade BMC.
>>
>> Chanh Nguyen (6):
>>    ARM: dts: aspeed: mtjade, mtmitchell: Add OCP temperature sensors
>>    ARM: dts: aspeed: mtmitchell: Add I2C temperature sensor alias ports
>>    ARM: dts: aspeed: mtmitchell: Add I2C Riser card alias ports
>>    ARM: dts: aspeed: mtmitchell: Enable i2c10 and i2c15
>>    ARM: dts: aspeed: mtmitchell: Add LEDs
>>    ARM: dts: aspeed: mtmitchell: Add I2C FAN controllers
>>
>>   .../dts/aspeed/aspeed-bmc-ampere-mtjade.dts   |  16 ++
>>   .../aspeed/aspeed-bmc-ampere-mtmitchell.dts   | 152 ++++++++++++++++++
>>   2 files changed, 168 insertions(+)
>>
>> --
>> 2.43.0
>>
>>
>>
> 
> 
> My bot found new DTB warnings on the .dts files added or changed in this
> series.
> 
> Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
> are fixed by another series. Ultimately, it is up to the platform
> maintainer whether these warnings are acceptable or not. No need to reply
> unless the platform maintainer has comments.
> 
> If you already ran DT checks and didn't see these error(s), then
> make sure dt-schema is up to date:
> 
>    pip3 install dtschema --upgrade
> 
> 
> New warnings running 'make CHECK_DTBS=y aspeed/aspeed-bmc-ampere-mtjade.dtb aspeed/aspeed-bmc-ampere-mtmitchell.dtb' for 20240801091217.1408809-1-chanh@...amperecomputing.com:
> 
> arch/arm/boot/dts/aspeed/aspeed-bmc-ampere-mtmitchell.dtb: /ahb/apb/bus@...8a000/i2c@.../fan-controller0@20: failed to match any schema with compatible: ['maxim,max31790']
> arch/arm/boot/dts/aspeed/aspeed-bmc-ampere-mtmitchell.dtb: /ahb/apb/bus@...8a000/i2c@.../fan-controller1@2f: failed to match any schema with compatible: ['maxim,max31790']
> 
> 

Thank Rob for your review!

I am aware of the new warnings you mentioned. For more information, the 
schema binding of "maxim,max31790" is being progressed by other series  
https://lore.kernel.org/lkml/20240414042246.8681-2-chanh@os.amperecomputing.com/ 


Best regards,
Chanh

> 
> 
>