linux-kernel - Re: [PATCH] staging: media: atomisp: Add parentheses around macro definitions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <878qxe41c8.fsf@melete.silentflame.com>
Date: Sat, 03 Aug 2024 13:33:43 +0800
From: Sean Whitton <spwhitton@...hitton.name>
To: Dan Carpenter <dan.carpenter@...aro.org>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
  ~lkcamp/patches@...ts.sr.ht,  helen.koike@...labora.com,  Hans de Goede
 <hdegoede@...hat.com>,  Mauro Carvalho Chehab <mchehab@...nel.org>,
  Sakari Ailus <sakari.ailus@...ux.intel.com>,
  linux-media@...r.kernel.org,  linux-staging@...ts.linux.dev,
  linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: media: atomisp: Add parentheses around macro
 definitions

Hello,

On Fri 02 Aug 2024 at 11:28pm -05, Dan Carpenter wrote:

> *You* need to figure out what the proper thing is.  Not us.  That's the
> difficult part of writing a patch.  Once you know what the correct thing
> is, then the rest is just typing.
>
> That business of defining STORAGE_CLASS_SP_C is weird.  Figure out the
> authors intention and find a better way to do it.
>
> Figure out why your code compiled as well because putting parentheses
> around (static inline) is a syntax error.

I asked follow-up questions because it seems like at least partially a
matter of style to say that the business of defining STORAGE_CLASS_SP_C
is weird.  Maybe there is a better approach than what is currently done,
but maybe there isn't.  Maybe the checkpatch warning should just be
suppressed (if that's something that can be done).  I would be grateful
for some additional pointers.

-- 
Sean Whitton