[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <80fd755e-071e-44d3-a3b9-6ca16e97a447@kernel.org>
Date: Sun, 4 Aug 2024 10:33:57 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Frank Li <Frank.li@....com>
Cc: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor Dooley <conor+dt@...nel.org>, Shawn Guo <shawnguo@...nel.org>,
Sascha Hauer <s.hauer@...gutronix.de>,
Pengutronix Kernel Team <kernel@...gutronix.de>,
Fabio Estevam <festevam@...il.com>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@...r.kernel.org>,
"open list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" <imx@...ts.linux.dev>,
"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
<linux-arm-kernel@...ts.infradead.org>,
open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/1] arm64: dts: imx93: add lpi2c1 and child node
On 02/08/2024 16:31, Frank Li wrote:
> On Fri, Aug 02, 2024 at 09:25:54AM +0200, Krzysztof Kozlowski wrote:
>> On 01/08/2024 18:09, Frank Li wrote:
>>> From: Clark Wang <xiaoning.wang@....com>
>>>
>>> Add lpi2c1 and child node for imx93-11x11-evk board.
>>
>> Why? What for? What are these? We see all this from the diff, so commit
>> msg should explain why and what do you want to achieve.
>
> I really don't know how to explain why/what for these straing forward
> thing, hardware board has such component, just add it dts file.
You can explain what you are adding in terms of hardware. "child node"
is really useless description.
Best regards,
Krzysztof
Powered by blists - more mailing lists