linux-kernel - Re: [PATCH v2] wifi: b43: Constify struct lpphy_tx_gain_table

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240804100526.19942fbe@barney>
Date: Sun, 4 Aug 2024 10:05:26 +0200
From: Michael Büsch <m@...s.ch>
To: Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc: Kalle Valo <kvalo@...nel.org>, linux-kernel@...r.kernel.org,
 kernel-janitors@...r.kernel.org, linux-wireless@...r.kernel.org,
 b43-dev@...ts.infradead.org
Subject: Re: [PATCH v2] wifi: b43: Constify struct lpphy_tx_gain_table_entry

On Sun,  4 Aug 2024 08:32:44 +0200
Christophe JAILLET <christophe.jaillet@...adoo.fr> wrote:

> 'struct lpphy_tx_gain_table_entry' are not modified in this driver.
> 
> Constifying this structure moves some data to a read-only section, so
> increase overall security.
> 
> On a x86_64, with allmodconfig:
> Before:
> ======
>    text	   data	    bss	    dec	    hex	filename
>   16481	   6232	      0	  22713	   58b9	drivers/net/wireless/broadcom/b43/tables_lpphy.o
> 
> After:
> =====
>    text	   data	    bss	    dec	    hex	filename
>   22305	    395	      0	  22700	   58ac	drivers/net/wireless/broadcom/b43/tables_lpphy.o
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> ---
> Compile tested-only.
> 
> lpphy_write_gain_table() and lpphy_write_gain_table_bulk() could also be
> made static and removed from tables_lpphy.h, but without knowing the reason
> why it is done this way, I've preferred to leave it as-is.
> 
> Changes in v2:
>   - remove unrelated and un-needed constification   [Michael Büsch]
>   - update numbers in the commit log


Acked-By: Michael Büsch <m@...s.ch>


-- 
Michael Büsch
https://bues.ch/

Content of type "application/pgp-signature" skipped