linux-kernel - Re: [PATCH v2] usb: dwc3: Runtime get and put usb power

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAGZ6i=0shz-2cW6BD-MUm4jEz9hXCM9ZsP5kwD9bS52PZgmYdQ@mail.gmail.com>
Date: Sun, 4 Aug 2024 17:00:40 +0800
From: Kyle Tso <kyletso@...gle.com>
To: Thinh.Nguyen@...opsys.com, gregkh@...uxfoundation.org, raychi@...gle.com
Cc: badhri@...gle.com, linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org, 
	royluo@...gle.com, bvanassche@....org, stable@...r.kernel.org
Subject: Re: [PATCH v2] usb: dwc3: Runtime get and put usb power_supply handle

On Fri, Aug 2, 2024 at 3:55 PM Kyle Tso <kyletso@...gle.com> wrote:
>
> On Fri, Jul 26, 2024 at 8:28 PM Kyle Tso <kyletso@...gle.com> wrote:
> >
> > It is possible that the usb power_supply is registered after the probe
> > of dwc3. In this case, trying to get the usb power_supply during the
> > probe will fail and there is no chance to try again. Also the usb
> > power_supply might be unregistered at anytime so that the handle of it
> > in dwc3 would become invalid. To fix this, get the handle right before
> > calling to power_supply functions and put it afterward.
> >
> > Fixes: 6f0764b5adea ("usb: dwc3: add a power supply for current control")
> > Cc: stable@...r.kernel.org
> > Signed-off-by: Kyle Tso <kyletso@...gle.com>
> > ---
> > v1 -> v2:
> > - move power_supply_put out of interrupt context
> >
>
> Hi maintainers,
>
> It seems that there are some problems in version 2. I will send out
> version 3 later.
>
> Kyle

version 3 sent

https://lore.kernel.org/all/20240804084612.2561230-1-kyletso@google.com/

Kyle