linux-kernel - Re: [v2] wifi: brcmfmac: fwsignal: Use struct_size() to simplify brcmf_fws

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <172276256603.2804131.6125500029059282435.kvalo@kernel.org>
Date: Sun,  4 Aug 2024 09:09:27 +0000 (UTC)
From: Kalle Valo <kvalo@...nel.org>
To: Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc: Arend van Spriel <arend.vanspriel@...adcom.com>,
 linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
 Christophe JAILLET <christophe.jaillet@...adoo.fr>,
 linux-wireless@...r.kernel.org, brcm80211@...ts.linux.dev,
 brcm80211-dev-list.pdl@...adcom.com
Subject: Re: [v2] wifi: brcmfmac: fwsignal: Use struct_size() to simplify
 brcmf_fws_rxreorder()

Christophe JAILLET <christophe.jaillet@...adoo.fr> wrote:

> In the "struct brcmf_ampdu_rx_reorder", change the 'pktslots' field into
> flexible array.
> 
> It saves the size of a pointer when the memory is allocated and avoids
> an indirection when the array is used.
> It also removes the usage of a pointer arithmetic and saves a few lines of
> code.
> 
> Finally, struct_size() can be used. It is not a must have here, because
> it is easy to see that buf_size can not overflow, but still, it is a good
> practice.
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> Acked-by: Arend van Spriel <arend.vanspriel@...adcom.com>

Patch applied to wireless-next.git, thanks.

16b31ecb8029 wifi: brcmfmac: fwsignal: Use struct_size() to simplify brcmf_fws_rxreorder()

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/f4ca6b887ca1290c71e76247218adea4d1c42442.1721547559.git.christophe.jaillet@wanadoo.fr/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches