linux-kernel - Re: [PATCH v5] wifi: mt76: mt7915: add wds support when wed is enabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID:
 <TY3P286MB2611C363575C77278946A4B498BD2@TY3P286MB2611.JPNP286.PROD.OUTLOOK.COM>
Date: Sun, 4 Aug 2024 17:28:20 +0800
From: Shengyu Qu <wiagn233@...look.com>
To: kernel test robot <lkp@...el.com>, nbd@....name, lorenzo@...nel.org,
 ryder.lee@...iatek.com, shayne.chen@...iatek.com, sean.wang@...iatek.com,
 kvalo@...nel.org, matthias.bgg@...il.com,
 angelogioacchino.delregno@...labora.com, chui-hao.chiu@...iatek.com,
 emmanuel.grumbach@...el.com, StanleyYP.Wang@...iatek.com,
 meichia.chiu@...iatek.com, johannes.berg@...el.com, quic_adisi@...cinc.com,
 allen.ye@...iatek.com, bo.jiao@...iatek.com, linux-wireless@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-mediatek@...ts.infradead.org
Cc: wiagn233@...look.com, oe-kbuild-all@...ts.linux.dev,
 Sujuan Chen <sujuan.chen@...iatek.com>
Subject: Re: [PATCH v5] wifi: mt76: mt7915: add wds support when wed is
 enabled

This error report is a false warning. "struct mtk_wed_device" needs
"CONFIG_NET_MEDIATEK_SOC_WED" to be defined.

Best regards,
Shengyu

在 2024/8/4 10:43, kernel test robot 写道:
> Hi Shengyu,
> 
> kernel test robot noticed the following build errors:
> 
> [auto build test ERROR on wireless-next/main]
> [also build test ERROR on wireless/main linus/master v6.11-rc1 next-20240802]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch#_base_tree_information]
> 
> url:    https://github.com/intel-lab-lkp/linux/commits/Shengyu-Qu/wifi-mt76-mt7915-add-wds-support-when-wed-is-enabled/20240803-231632
> base:   https://git.kernel.org/pub/scm/linux/kernel/git/wireless/wireless-next.git main
> patch link:    https://lore.kernel.org/r/TY3P286MB2611CB2F4F5FA27D782AA80A98BC2%40TY3P286MB2611.JPNP286.PROD.OUTLOOK.COM
> patch subject: [PATCH v5] wifi: mt76: mt7915: add wds support when wed is enabled
> config: x86_64-buildonly-randconfig-003-20240804 (https://download.01.org/0day-ci/archive/20240804/202408041039.BqVRJOqp-lkp@intel.com/config)
> compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240804/202408041039.BqVRJOqp-lkp@intel.com/reproduce)
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@...el.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202408041039.BqVRJOqp-lkp@intel.com/
> 
> All errors (new ones prefixed by >>):
> 
>     drivers/net/wireless/mediatek/mt76/mt7915/mcu.c: In function 'mt7915_mcu_init_firmware':
>>> drivers/net/wireless/mediatek/mt76/mt7915/mcu.c:2363:67: error: 'struct mtk_wed_device' has no member named 'rev_id'
>      2363 |                                                 dev->mt76.mmio.wed.rev_id, 0);
>           |                                                                   ^
> 
> 
> vim +2363 drivers/net/wireless/mediatek/mt76/mt7915/mcu.c
> 
>    2322	
>    2323	int mt7915_mcu_init_firmware(struct mt7915_dev *dev)
>    2324	{
>    2325		int ret;
>    2326	
>    2327		/* force firmware operation mode into normal state,
>    2328		 * which should be set before firmware download stage.
>    2329		 */
>    2330		mt76_wr(dev, MT_SWDEF_MODE, MT_SWDEF_NORMAL_MODE);
>    2331	
>    2332		ret = mt7915_driver_own(dev, 0);
>    2333		if (ret)
>    2334			return ret;
>    2335		/* set driver own for band1 when two hif exist */
>    2336		if (dev->hif2) {
>    2337			ret = mt7915_driver_own(dev, 1);
>    2338			if (ret)
>    2339				return ret;
>    2340		}
>    2341	
>    2342		ret = mt7915_load_firmware(dev);
>    2343		if (ret)
>    2344			return ret;
>    2345	
>    2346		set_bit(MT76_STATE_MCU_RUNNING, &dev->mphy.state);
>    2347		ret = mt7915_mcu_fw_log_2_host(dev, MCU_FW_LOG_WM, 0);
>    2348		if (ret)
>    2349			return ret;
>    2350	
>    2351		ret = mt7915_mcu_fw_log_2_host(dev, MCU_FW_LOG_WA, 0);
>    2352		if (ret)
>    2353			return ret;
>    2354	
>    2355		if (mtk_wed_device_active(&dev->mt76.mmio.wed)) {
>    2356			if (is_mt7915(&dev->mt76) ||
>    2357			    !mtk_wed_get_rx_capa(&dev->mt76.mmio.wed))
>    2358				ret = mt7915_mcu_wa_cmd(dev, MCU_WA_PARAM_CMD(CAPABILITY),
>    2359							0, 0, 0);
>    2360			else
>    2361				ret = mt7915_mcu_wa_cmd(dev, MCU_WA_PARAM_CMD(SET),
>    2362							MCU_WA_PARAM_WED_VERSION,
>> 2363							dev->mt76.mmio.wed.rev_id, 0);
>    2364			if (ret)
>    2365				return ret;
>    2366		}
>    2367	
>    2368		ret = mt7915_mcu_set_mwds(dev, 1);
>    2369		if (ret)
>    2370			return ret;
>    2371	
>    2372		ret = mt7915_mcu_set_muru_ctrl(dev, MURU_SET_PLATFORM_TYPE,
>    2373					       MURU_PLATFORM_TYPE_PERF_LEVEL_2);
>    2374		if (ret)
>    2375			return ret;
>    2376	
>    2377		ret = mt7915_mcu_init_rx_airtime(dev);
>    2378		if (ret)
>    2379			return ret;
>    2380	
>    2381		return mt7915_mcu_set_red(dev, mtk_wed_device_active(&dev->mt76.mmio.wed));
>    2382	}
>    2383	
> 

Download attachment "OpenPGP_0xE3520CC91929C8E7.asc" of type "application/pgp-keys" (6869 bytes)

Download attachment "OpenPGP_signature.asc" of type "application/pgp-signature" (841 bytes)