linux-kernel - Re: [PATCH 2/3] dt-bindings: Add power-domain header for RK3576 SoCs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e04258dc-07c4-45c7-90d4-bc1ed9eb100b@kernel.org>
Date: Sun, 4 Aug 2024 11:56:39 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Detlev Casanova <detlev.casanova@...labora.com>,
 linux-kernel@...r.kernel.org
Cc: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Heiko Stuebner <heiko@...ech.de>,
 Ulf Hansson <ulf.hansson@...aro.org>,
 Geert Uytterhoeven <geert+renesas@...der.be>,
 "Rafael J . Wysocki" <rafael@...nel.org>,
 Finley Xiao <finley.xiao@...k-chips.com>, Jagan Teki <jagan@...eble.ai>,
 Elaine Zhang <zhangqing@...k-chips.com>, devicetree@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-rockchip@...ts.infradead.org,
 linux-pm@...r.kernel.org
Subject: Re: [PATCH 2/3] dt-bindings: Add power-domain header for RK3576 SoCs

On 02/08/2024 17:14, Detlev Casanova wrote:
> From: Finley Xiao <finley.xiao@...k-chips.com>
> 
> Define power domain IDs as described in the TRM.

Please use subject prefixes matching the subsystem. You can get them for
example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
your patch is touching. For bindings, the preferred subjects are
explained here:
https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters

> 
> Signed-off-by: Finley Xiao <finley.xiao@...k-chips.com>
> [reword]
> Signed-off-by: Detlev Casanova <detlev.casanova@...labora.com>
> ---
>  include/dt-bindings/power/rk3576-power.h | 30 ++++++++++++++++++++++++
>  1 file changed, 30 insertions(+)
>  create mode 100644 include/dt-bindings/power/rk3576-power.h

This is part of bindings.

> 
> diff --git a/include/dt-bindings/power/rk3576-power.h b/include/dt-bindings/power/rk3576-power.h

Missing vendor prefix. This should be named after compatible.

> new file mode 100644
> index 0000000000000..cb33a32c1aed9
> --- /dev/null
> +++ b/include/dt-bindings/power/rk3576-power.h
> @@ -0,0 +1,30 @@
> +/* SPDX-License-Identifier: (GPL-2.0+ OR MIT) */

Weird license.

Best regards,
Krzysztof