linux-kernel - Re: [PATCH v5] wifi: mt76: mt7915: add wds support when wed is enabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <TY3P286MB261189441C7AF5E7FBA0634298BD2@TY3P286MB2611.JPNP286.PROD.OUTLOOK.COM>
Date: Sun, 4 Aug 2024 20:17:44 +0800
From: Shengyu Qu <wiagn233@...look.com>
To: Kalle Valo <kvalo@...nel.org>
Cc: wiagn233@...look.com, kernel test robot <lkp@...el.com>, nbd@....name,
 lorenzo@...nel.org, ryder.lee@...iatek.com, shayne.chen@...iatek.com,
 sean.wang@...iatek.com, matthias.bgg@...il.com,
 angelogioacchino.delregno@...labora.com, chui-hao.chiu@...iatek.com,
 emmanuel.grumbach@...el.com, StanleyYP.Wang@...iatek.com,
 meichia.chiu@...iatek.com, johannes.berg@...el.com, quic_adisi@...cinc.com,
 allen.ye@...iatek.com, bo.jiao@...iatek.com, linux-wireless@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-mediatek@...ts.infradead.org, oe-kbuild-all@...ts.linux.dev,
 Sujuan Chen <sujuan.chen@...iatek.com>
Subject: Re: [PATCH v5] wifi: mt76: mt7915: add wds support when wed is
 enabled

You are right. I'm thinking about changing the code like this:

#ifdef CONFIG_NET_MEDIATEK_SOC_WED
	if (mtk_wed_device_active(&dev->mt76.mmio.wed)) {
		if (is_mt7915(&dev->mt76) ||
		    !mtk_wed_get_rx_capa(&dev->mt76.mmio.wed))
			ret = mt7915_mcu_wa_cmd(dev, MCU_WA_PARAM_CMD(CAPABILITY),
						0, 0, 0);
		else
			ret = mt7915_mcu_wa_cmd(dev, MCU_WA_PARAM_CMD(SET),
						MCU_WA_PARAM_WED_VERSION,
						dev->mt76.mmio.wed.rev_id, 0);
		if (ret)
			return ret;
	}
#endif

Do you think this is ok?

Best regards,
Shengyu

在 2024/8/4 17:56, Kalle Valo 写道:
> Shengyu Qu <wiagn233@...look.com> writes:
> 
>> This error report is a false warning. "struct mtk_wed_device" needs
>> "CONFIG_NET_MEDIATEK_SOC_WED" to be defined.
> 
> I didn't investigate anything but based on your description that sounds
> wrong. The code should should not be compiled if it depends on
> CONFIG_NET_MEDIATEK_SOC_WED but that's not set. We have zero rule for
> compilation errors or warnings.
> 

Download attachment "OpenPGP_0xE3520CC91929C8E7.asc" of type "application/pgp-keys" (6869 bytes)

Download attachment "OpenPGP_signature.asc" of type "application/pgp-signature" (841 bytes)