linux-kernel - Re: [PATCH] USB: core: hub_port_reset: Remove extra 40 ms reset recovery time

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3ec64ec7-5e10-4d24-bc6b-f205154f2cf8@rowland.harvard.edu>
Date: Sun, 4 Aug 2024 09:19:19 -0400
From: Alan Stern <stern@...land.harvard.edu>
To: Paul Menzel <pmenzel@...gen.mpg.de>
Cc: Mathias Nyman <mathias.nyman@...el.com>,
	Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Kai-Heng Feng <kai.heng.feng@...onical.com>,
	Hans de Goede <hdegoede@...hat.com>, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] USB: core: hub_port_reset: Remove extra 40 ms reset
 recovery time

On Sun, Aug 04, 2024 at 09:15:34AM +0200, Paul Menzel wrote:
> [To: +Heikki]
> 
> 
> Dear Alan, dear Heikki,
> 
> 
> Am 26.07.24 um 19:48 schrieb Alan Stern:

...

> > It's probably an xHCI thing -- the hardware may stop providing power to
> > the ports during S3 suspend, or something like that.  The xHCI people
> > may have a better idea of what's going on.
> 
> Heikki, can you confirm this. I am attaching the logs with

You should be asking Mathias, the xHCI maintainer.

>     echo 'file drivers/usb/* +p' | sudo tee
> /sys/kernel/debug/dynamic_debug/control

...

> [  149.185600] usb 1-3: usb suspend, wakeup 0
> [  149.185642] xhci_hcd 0000:00:14.0: Cancel URB 000000003e45896a, dev 4, ep 0x81, starting at offset 0x102ef1010
> [  149.185661] usb usb2: usb auto-resume
> [  149.185664] xhci_hcd 0000:00:14.0: // Ding dong!
> [  149.185736] xhci_hcd 0000:00:14.0: Stopped on Transfer TRB for slot 2 ep 2
> [  149.185745] xhci_hcd 0000:00:14.0: Removing canceled TD starting at 0x102ef1010 (dma) in stream 0 URB 000000003e45896a
> [  149.185753] xhci_hcd 0000:00:14.0: Set TR Deq ptr 0x102ef1020, cycle 1
> 
> [  149.185757] xhci_hcd 0000:00:14.0: // Ding dong!
> [  149.185763] xhci_hcd 0000:00:14.0: xhci_giveback_invalidated_tds: Keep cancelled URB 000000003e45896a TD as cancel_status is 2
> [  149.185770] xhci_hcd 0000:00:14.0: Successful Set TR Deq Ptr cmd, deq = @102ef1020
> [  149.185775] xhci_hcd 0000:00:14.0: xhci_handle_cmd_set_deq: Giveback cancelled URB 000000003e45896a TD
> [  149.185780] xhci_hcd 0000:00:14.0: Giveback URB 000000003e45896a, len = 0, expected = 116, status = -115
> [  149.185788] xhci_hcd 0000:00:14.0: xhci_handle_cmd_set_deq: All TDs cleared, ring doorbell
> [  149.185810] hub 2-0:1.0: hub_resume
> [  149.185816] usb 1-4: usb suspend, wakeup 0
> [  149.185840] hub 1-0:1.0: hub_suspend
> [  149.185865] usb usb1: bus suspend, wakeup 0
> [  149.185894] xhci_hcd 0000:00:14.0: port 1-4 not suspended
> [  149.185899] xhci_hcd 0000:00:14.0: port 1-3 not suspended

I have to wonder why xhci-hcd says ports 1-3 and 1-4 are not suspended,
when only a few lines earlier the log says that devices 1-3 and 1-4
have gone into USB suspend.

Alan Stern