linux-kernel - Re: [PATCH 07/12] selftests/nolibc: determine $(srctree) first

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <812c6752-4404-4082-910c-732e049aa54e@t-8ch.de>
Date: Sun, 4 Aug 2024 17:55:48 +0200
From: Thomas Weißschuh <linux@...ssschuh.net>
To: Willy Tarreau <w@....eu>
Cc: Shuah Khan <shuah@...nel.org>, linux-kernel@...r.kernel.org, 
	linux-kselftest@...r.kernel.org
Subject: Re: [PATCH 07/12] selftests/nolibc: determine $(srctree) first

On 2024-08-03 11:40:24+0000, Willy Tarreau wrote:
> On Sun, Jul 28, 2024 at 12:10:01PM +0200, Thomas Weißschuh wrote:
> > Avoid needing relative includes.
> 
> I'm not opposed, but what's the benefit ? IMHO relative paths are
> generally more flexible and robust. you could imagine a completely
> made up example in which you have a symlink to selftests/nolibc in
> your home dir, which works perfectly with relative paths when you
> cd into it while it would not anymore with absolute paths (unless
> you use cd -P).

This commit is solely about relative includes in the nolibc-test
Makefile.
The actual code is unaffected.

include ../../../scripts/utilities.mak
->
include $(srctree)/tools/scripts/utilities.mak

This commit is not necessary, just a cleanup.
IMO consistently using $(srctree) is nicer.

And yes the message for this commit is really not great.

> Thus if we are decided to lose that flexibility at least it should
> be argumented in the commit message.
> 
> Thanks,
> Willy