linux-kernel - Re: [PATCH 2/5] Compiler Attributes: remove unneeded version comments for older LLVMs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240804175510.GB2627063@thelio-3990X>
Date: Sun, 4 Aug 2024 10:55:10 -0700
From: Nathan Chancellor <nathan@...nel.org>
To: Miguel Ojeda <ojeda@...nel.org>
Cc: Nick Desaulniers <ndesaulniers@...gle.com>,
	Bill Wendling <morbo@...gle.com>,
	Justin Stitt <justinstitt@...gle.com>, llvm@...ts.linux.dev,
	linux-kernel@...r.kernel.org, patches@...ts.linux.dev
Subject: Re: [PATCH 2/5] Compiler Attributes: remove unneeded version
 comments for older LLVMs

On Sat, Aug 03, 2024 at 07:19:30PM +0200, Miguel Ojeda wrote:
> The kernel upgraded to support only LLVM >= 13 in commit 9c1b86f8ce04
> ("kbuild: raise the minimum supported version of LLVM to 13.0.1"),
> thus remove version comments that are not needed anymore.
> 
> Signed-off-by: Miguel Ojeda <ojeda@...nel.org>

Whoops :)

Reviewed-by: Nathan Chancellor <nathan@...nel.org>

> ---
>  include/linux/compiler_attributes.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/include/linux/compiler_attributes.h b/include/linux/compiler_attributes.h
> index b658136e6cda..5d171a7f8cbd 100644
> --- a/include/linux/compiler_attributes.h
> +++ b/include/linux/compiler_attributes.h
> @@ -256,7 +256,7 @@
>  #endif
>  
>  /*
> - * Optional: only supported since GCC >= 7.1, clang >= 13.0.
> + * Optional: only supported since GCC >= 7.1
>   *
>   *      gcc: https://gcc.gnu.org/onlinedocs/gcc/Common-Function-Attributes.html#index-no_005fprofile_005finstrument_005ffunction-function-attribute
>   *    clang: https://clang.llvm.org/docs/AttributeReference.html#no-profile-instrument-function
> @@ -275,7 +275,7 @@
>  #define __noreturn                      __attribute__((__noreturn__))
>  
>  /*
> - * Optional: only supported since GCC >= 11.1, clang >= 7.0.
> + * Optional: only supported since GCC >= 11.1
>   *
>   *   gcc: https://gcc.gnu.org/onlinedocs/gcc/Common-Function-Attributes.html#index-no_005fstack_005fprotector-function-attribute
>   *   clang: https://clang.llvm.org/docs/AttributeReference.html#no-stack-protector-safebuffers
> -- 
> 2.46.0
> 
>