linux-kernel - Re: [PATCH net-next v2] staging: rtl8723bs: Delete unnecessary braces for single statement blocks in xmit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a4cb6e95-3a61-4e2c-b401-916794a4ed02@gmail.com>
Date: Sun, 4 Aug 2024 21:02:23 +0200
From: Philipp Hortmann <philipp.g.hortmann@...il.com>
To: jiwonaid0@...il.com, gregkh@...uxfoundation.org
Cc: linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v2] staging: rtl8723bs: Delete unnecessary braces
 for single statement blocks in xmit_linux.c

On 8/4/24 13:32, jiwonaid0@...il.com wrote:
> From: Jiwon Kim <jiwonaid0@...il.com>
please remove the above line. It is not needed
> 
> Delete braces {} for single statement blocks to shorten code.
> 
> Signed-off-by: Jiwon Kim <jiwonaid0@...il.com>
> ---
> v2: Fix commit message
You changed the description and the subject.
> ---
>   drivers/staging/rtl8723bs/os_dep/xmit_linux.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/os_dep/xmit_linux.c b/drivers/staging/rtl8723bs/os_dep/xmit_linux.c
> index 1eeabfffd6d2..e0736707a211 100644
> --- a/drivers/staging/rtl8723bs/os_dep/xmit_linux.c
> +++ b/drivers/staging/rtl8723bs/os_dep/xmit_linux.c
> @@ -144,9 +144,8 @@ static int rtw_mlcst2unicst(struct adapter *padapter, struct sk_buff *skb)
>   		psta = list_entry(plist, struct sta_info, asoc_list);
>   
>   		stainfo_offset = rtw_stainfo_offset(pstapriv, psta);
> -		if (stainfo_offset_valid(stainfo_offset)) {
> +		if (stainfo_offset_valid(stainfo_offset))
>   			chk_alive_list[chk_alive_num++] = stainfo_offset;
> -		}
>   	}
>   	spin_unlock_bh(&pstapriv->asoc_list_lock);
>   

Hi Jiwon,

sorry for bothering again. Please fix above comments.

Please also remove the "net-next" in the subject. Sorry I missed to 
mention this earlier.

If you send in a third version of this patch please use a change 
history. Description from Dan under:
https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/

Thanks for your support.

Bye Philipp