linux-kernel - Re: [PATCH] sparc/vdso: Add helper function for 64-bit right shift on 32-bit target

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87y15c5c9u.ffs@tglx>
Date: Sun, 04 Aug 2024 21:16:45 +0200
From: Thomas Gleixner <tglx@...utronix.de>
To: Koakuma <koachan@...tonmail.com>
Cc: Koakuma via B4 Relay <devnull+koachan.protonmail.com@...nel.org>, "David
 S. Miller" <davem@...emloft.net>, Andreas Larsson <andreas@...sler.com>,
 Andy Lutomirski <luto@...nel.org>, Vincenzo Frascino
 <vincenzo.frascino@....com>, Nathan Chancellor <nathan@...nel.org>, Nick
 Desaulniers <ndesaulniers@...gle.com>, Bill Wendling <morbo@...gle.com>,
 Justin Stitt <justinstitt@...gle.com>, sparclinux@...r.kernel.org,
 linux-kernel@...r.kernel.org, llvm@...ts.linux.dev
Subject: Re: [PATCH] sparc/vdso: Add helper function for 64-bit right shift
 on 32-bit target

On Sun, Aug 04 2024 at 17:30, Koakuma wrote:
> Thomas Gleixner <tglx@...utronix.de> wrote:
>> Why does this sparc'ism need to be in generic code?
>
> Doesn't x86 also have a couple functions that live in math64.h anyway?

No. Both functions are used in the generic lib/vdso/ code.

> That's why I thought it is fine to put it in there...
>
> In any case, though, I am open to moving the function to sparc directory,
> if that is indeed the proper place for that function.

I think so as sparc is having it's own VDSO implementation and does not
use the generic one.

Thanks,

        tglx