[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <8aa45bc5-b819-4979-80b5-6d90a772b117@lunn.ch>
Date: Mon, 5 Aug 2024 01:11:16 +0200
From: Andrew Lunn <andrew@...n.ch>
To: "Jan Petrous (OSS)" <jan.petrous@....nxp.com>
Cc: Maxime Coquelin <mcoquelin.stm32@...il.com>,
Alexandre Torgue <alexandre.torgue@...s.st.com>,
dl-S32 <S32@....com>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"linux-stm32@...md-mailman.stormreply.com" <linux-stm32@...md-mailman.stormreply.com>,
"linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>,
Claudiu Manoil <claudiu.manoil@....com>,
"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH 1/6] net: driver: stmmac: extend CSR calc support
> #define STMMAC_CSR_20_35M 0x2 /* MDC = clk_scr_i/16 */
> #define STMMAC_CSR_35_60M 0x3 /* MDC = clk_scr_i/26 */
> #define STMMAC_CSR_150_250M 0x4 /* MDC = clk_scr_i/102 */
> -#define STMMAC_CSR_250_300M 0x5 /* MDC = clk_scr_i/122 */
> +#define STMMAC_CSR_250_300M 0x5 /* MDC = clk_scr_i/124 */
That should probably be called out in the commit message. It is not a
fix as such, since it is just a comment, but as a reviewer i had a
double take when i noticed this.,
Andrew
---
pw-bot: cr
Powered by blists - more mailing lists