linux-kernel - Re: [PATCH v9 2/3] PCI/DOE: Expose the DOE features via sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Zq8X0t0lMLQ12oIQ@wunner.de>
Date: Sun, 4 Aug 2024 07:55:30 +0200
From: Lukas Wunner <lukas@...ner.de>
To: Bjorn Helgaas <helgaas@...nel.org>
Cc: Alistair Francis <alistair23@...il.com>, linux-pci@...r.kernel.org,
	Jonathan.Cameron@...wei.com, alex.williamson@...hat.com,
	christian.koenig@....com, kch@...dia.com,
	gregkh@...uxfoundation.org, logang@...tatee.com,
	linux-kernel@...r.kernel.org, chaitanyak@...dia.com,
	rdunlap@...radead.org, Alistair Francis <alistair.francis@....com>
Subject: Re: [PATCH v9 2/3] PCI/DOE: Expose the DOE features via sysfs

On Thu, Oct 19, 2023 at 11:58:29AM -0500, Bjorn Helgaas wrote:
> Is it feasible to build an attribute group in pci_doe_init() and add
> it to dev->groups so device_add() will automatically add them?

Note that pcibios_device_add() in arch/s390/pci/pci.c does this:

	pdev->dev.groups = zpci_attr_groups;

... which prevents usage of pdev->dev.groups for anything else.

This needs to be cleaned up first before the PCI core can allocate
and fill generic attribute groups on enumeration.

Thanks,

Lukas