linux-kernel - Re: [PATCH V2] lockdep: suggest the fix for "lockdep bfs error:-1" on print_bfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZrEPLFDGSSS3Dh80@tardis>
Date: Mon, 5 Aug 2024 10:43:08 -0700
From: Boqun Feng <boqun.feng@...il.com>
To: "Luis Claudio R. Goncalves" <lgoncalv@...hat.com>
Cc: Peter Zijlstra <peterz@...radead.org>, Ingo Molnar <mingo@...hat.com>,
	Will Deacon <will@...nel.org>, Waiman Long <longman@...hat.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH V2] lockdep: suggest the fix for "lockdep bfs error:-1"
 on print_bfs_bug

On Tue, Jul 30, 2024 at 02:45:47PM -0300, Luis Claudio R. Goncalves wrote:
> When lockdep fails while performing the Breadth-first-search operation
> due to lack of memory, hint that increasing the value of the config
> switch LOCKDEP_CIRCULAR_QUEUE_BITS should fix the warning.
> 
> Preface the scary backtrace with the suggestion:
> 
>     [  163.849242] Increase LOCKDEP_CIRCULAR_QUEUE_BITS to avoid this warning:
>     [  163.849248] ------------[ cut here ]------------
>     [  163.849250] lockdep bfs error:-1
>     [  163.849263] WARNING: CPU: 24 PID: 2454 at kernel/locking/lockdep.c:2091 print_bfs_bug+0x27/0x40
>     ...
> 
> Reviewed-by: Boqun Feng <boqun.feng@...il.com>
> Reviewed-by: Waiman Long <longman@...hat.com>
> Signed-off-by: Luis Claudio R. Goncalves <lgoncalv@...hat.com>

Queued at:

	https://git.kernel.org/pub/scm/linux/kernel/git/boqun/linux.git/
	lockdep-for-tip

Thanks!

Regards,
Boqun

> ---
> 
> Changes in v2:
>   - removed extra space from the if condition.
> 
>  kernel/locking/lockdep.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/kernel/locking/lockdep.c b/kernel/locking/lockdep.c
> index 58c88220a478a..1cf6d9fdddc9c 100644
> --- a/kernel/locking/lockdep.c
> +++ b/kernel/locking/lockdep.c
> @@ -2067,6 +2067,9 @@ static noinline void print_bfs_bug(int ret)
>  	/*
>  	 * Breadth-first-search failed, graph got corrupted?
>  	 */
> +	if (ret == BFS_EQUEUEFULL)
> +		pr_warn("Increase LOCKDEP_CIRCULAR_QUEUE_BITS to avoid this warning:\n");
> +
>  	WARN(1, "lockdep bfs error:%d\n", ret);
>  }
>  
> -- 
> 2.45.2
>