linux-kernel - Re: [PATCH] locking/lockdep: Simplify character output in seq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZrEP8QlnhztnwvWy@tardis>
Date: Mon, 5 Aug 2024 10:46:25 -0700
From: Boqun Feng <boqun.feng@...il.com>
To: Markus Elfring <Markus.Elfring@....de>
Cc: Christophe Jaillet <christophe.jaillet@...adoo.fr>,
	kernel-janitors@...r.kernel.org, Ingo Molnar <mingo@...hat.com>,
	Peter Zijlstra <peterz@...radead.org>,
	Waiman Long <longman@...hat.com>, Will Deacon <will@...nel.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] locking/lockdep: Simplify character output in seq_line()

On Mon, Jul 15, 2024 at 10:51:44AM +0200, Markus Elfring wrote:
> From: Markus Elfring <elfring@...rs.sourceforge.net>
> Date: Mon, 15 Jul 2024 10:42:17 +0200
> 
> Single characters should be put into a sequence.
> Thus use the corresponding function “seq_putc” for one selected call.
> 
> This issue was transformed by using the Coccinelle software.
> 
> Suggested-by: Christophe Jaillet <christophe.jaillet@...adoo.fr>
> Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>

Queued this at:

	https://git.kernel.org/pub/scm/linux/kernel/git/boqun/linux.git/ lockdep-for-tip

Thanks! And given Christophe's comment, the original one is not needed,
so drop it.

Regards,
Boqun

> ---
>  kernel/locking/lockdep_proc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/locking/lockdep_proc.c b/kernel/locking/lockdep_proc.c
> index e2bfb1db589d..6db0f43fc4df 100644
> --- a/kernel/locking/lockdep_proc.c
> +++ b/kernel/locking/lockdep_proc.c
> @@ -424,7 +424,7 @@ static void seq_line(struct seq_file *m, char c, int offset, int length)
>  	for (i = 0; i < offset; i++)
>  		seq_puts(m, " ");
>  	for (i = 0; i < length; i++)
> -		seq_printf(m, "%c", c);
> +		seq_putc(m, c);
>  	seq_puts(m, "\n");
>  }
> 
> --
> 2.45.2
>