linux-kernel - Re: [PATCH] timekeeping: Fix bogus clock_was_set() invocation in do

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANDhNCpej847tOsbnDFBLV6GLdPGDoM5JJ7d1-UYed+2AEarVQ@mail.gmail.com>
Date: Mon, 5 Aug 2024 10:50:40 -0700
From: John Stultz <jstultz@...gle.com>
To: Thomas Gleixner <tglx@...utronix.de>
Cc: LKML <linux-kernel@...r.kernel.org>, Stephen Boyd <sboyd@...nel.org>, 
	Anna-Maria Behnsen <anna-maria@...utronix.de>, Frederic Weisbecker <frederic@...nel.org>
Subject: Re: [PATCH] timekeeping: Fix bogus clock_was_set() invocation in do_adjtimex()

On Sat, Aug 3, 2024 at 8:07 AM Thomas Gleixner <tglx@...utronix.de> wrote:
>
> The addition of the bases argument to clock_was_set() fixed up all call
> sites correctly except for do_adjtimex(). This uses CLOCK_REALTIME
> instead of CLOCK_SET_WALL as argument. CLOCK_REALTIME is 0.
>
> As a result the effect of that clock_was_set() notification is incomplete
> and might result in timers expiring late because the hrtimer code does
> not re-evaluate the affected clock bases.
>
> Use CLOCK_SET_WALL instead of CLOCK_REALTIME to tell the hrtimers code
> which clock bases need to be re-evaluated.

Acked-by: John Stultz <jstultz@...gle.com>

My only thought here is maybe renaming CLOCK_SET_WALL and
CLOCK_SET_BOOT to something like:
  BASEMASK_WALL_CLOCK_SET and BASEMASK_BOOT_CLOCK_SET

Just to avoid future naming mixups or confusion with clockids?

thanks
-john