linux-kernel - Re: [PATCH v6 2/2] ARM: dts: aspeed: catalina: add Meta Catalina BMC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1176b2ddb609b462004fa7e7b36fe6657b89bbf0.camel@codeconstruct.com.au>
Date: Mon, 05 Aug 2024 13:22:12 +0930
From: Andrew Jeffery <andrew@...econstruct.com.au>
To: Potin Lai <potin.lai.pt@...il.com>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski
	 <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, Joel Stanley
	 <joel@....id.au>, Patrick Williams <patrick@...cx.xyz>
Cc: devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, 
	linux-aspeed@...ts.ozlabs.org, linux-kernel@...r.kernel.org, Cosmo Chou
	 <cosmo.chou@...ntatw.com>, Potin Lai <potin.lai@...ntatw.com>, Krzysztof
	Kozlowski <krzysztof.kozlowski@...aro.org>
Subject: Re: [PATCH v6 2/2] ARM: dts: aspeed: catalina: add Meta Catalina BMC

Hi Potin,

On Fri, 2024-08-02 at 17:07 +0800, Potin Lai wrote:
> Add linux device tree entry for Meta(Facebook) Catalina compute-tray
> BMC using AT2600 SoC.
> 
> Signed-off-by: Potin Lai <potin.lai@...ntatw.com>

Running this past checkpatch gave me the following:

WARNING: From:/Signed-off-by: email address mismatch: 'From: Potin Lai <potin.lai.pt@...il.com>' != 'Signed-off-by: Potin Lai <potin.lai@...ntatw.com>'

If you can't send from potin.lai@...ntatw.com then perhaps you could
work around this by adding a `From: ...` line as the first line of your
commit message body as documented here:

https://docs.kernel.org/process/maintainer-tip.html#ordering-of-commit-tags

Alternatively, change your S-o-B tag to potin.lai.pt@...il.com

... 

> diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-catalina.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-catalina.dts
> new file mode 100644
> index 000000000000..70cec690f541
> --- /dev/null
> +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-catalina.dts
> @@ -0,0 +1,965 @@
> 

...

> +&gpio0 {
> +	pinctrl-names = "default";

Not sure why you need this, but I think it also causes the following
warning:

arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-catalina.dtb: gpio@...80000: 'pinctrl-0' is a dependency of 'pinctrl-names'

Might be best to drop it.

Andrew