[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240805191723.GA2636745-robh@kernel.org>
Date: Mon, 5 Aug 2024 13:17:23 -0600
From: Rob Herring <robh@...nel.org>
To: Heiko Stuebner <heiko@...ech.de>
Cc: lee@...nel.org, jdelvare@...e.com, linux@...ck-us.net,
dmitry.torokhov@...il.com, pavel@....cz, krzk+dt@...nel.org,
conor+dt@...nel.org, ukleinek@...ian.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org,
linux-rockchip@...ts.infradead.org, linux-hwmon@...r.kernel.org,
linux-input@...r.kernel.org, linux-leds@...r.kernel.org,
Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Subject: Re: [PATCH v3 1/7] dt-bindings: mfd: add binding for qnap,ts433-mcu
devices
On Wed, Jul 31, 2024 at 11:24:24PM +0200, Heiko Stuebner wrote:
> These MCUs can be found in network attached storage devices made by QNAP.
> They are connected to a serial port of the host device and provide
> functionality like LEDs, power-control and temperature monitoring.
>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> Signed-off-by: Heiko Stuebner <heiko@...ech.de>
> ---
> .../bindings/mfd/qnap,ts433-mcu.yaml | 43 +++++++++++++++++++
> 1 file changed, 43 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/mfd/qnap,ts433-mcu.yaml
>
> diff --git a/Documentation/devicetree/bindings/mfd/qnap,ts433-mcu.yaml b/Documentation/devicetree/bindings/mfd/qnap,ts433-mcu.yaml
> new file mode 100644
> index 0000000000000..5ae19d8faedbd
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mfd/qnap,ts433-mcu.yaml
> @@ -0,0 +1,43 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/mfd/qnap,ts433-mcu.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: QNAP NAS on-board Microcontroller
> +
> +maintainers:
> + - Heiko Stuebner <heiko@...ech.de>
> +
> +description:
> + QNAP embeds a microcontroller on their NAS devices adding system feature
> + as PWM Fan control, additional LEDs, power button status and more.
Doesn't really look like the binding is complete.
> +
> +properties:
> + compatible:
> + enum:
> + - qnap,ts433-mcu
> +
> + "#cooling-cells":
> + const: 2
> +
> + cooling-levels:
> + description: PWM duty cycle values corresponding to thermal cooling states.
> + $ref: /schemas/types.yaml#/definitions/uint32-array
> + items:
> + maximum: 255
These are fan properties and should be in a "fan" node referencing
hwmon/fan-common.yaml.
Rob
Powered by blists - more mailing lists