linux-kernel - Re: [PATCH v3] drm/amd/amdgpu: Properly tune the size of struct

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CADnq5_O3RtXU9pYb3ZJkzhNn1GoVUU9J=APkbxEMk07b7s9mCQ@mail.gmail.com>
Date: Mon, 5 Aug 2024 15:49:12 -0400
From: Alex Deucher <alexdeucher@...il.com>
To: WangYuli <wangyuli@...ontech.com>
Cc: alexander.deucher@....com, christian.koenig@....com, Xinhui.Pan@....com, 
	airlied@...il.com, daniel@...ll.ch, Jingwen.Chen2@....com, suhui@...china.com, 
	dan.carpenter@...aro.org, bokun.zhang@....com, chongli2@....com, 
	Luqmaan.Irshad@....com, amd-gfx@...ts.freedesktop.org, 
	dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org, 
	guanwentao@...ontech.com, shaoyang@...ontech.com, hongao@...ontech.com, 
	wenlunpeng <wenlunpeng@...ontech.com>
Subject: Re: [PATCH v3] drm/amd/amdgpu: Properly tune the size of struct

Applied.  Thanks!

On Wed, Jul 31, 2024 at 6:25 AM WangYuli <wangyuli@...ontech.com> wrote:
>
> The struct assertion is failed because sparse cannot parse
> `#pragma pack(push, 1)` and `#pragma pack(pop)` correctly.
> GCC's output is still 1-byte-aligned. No harm to memory layout.
>
> The error can be filtered out by sparse-diff, but sometimes
> multiple lines queezed into one, making the sparse-diff thinks
> its a new error. I'm trying to aviod this by fixing errors.
>
> Link: https://lore.kernel.org/all/20230620045919.492128-1-suhui@nfschina.com/
> Link: https://lore.kernel.org/all/93d10611-9fbb-4242-87b8-5860b2606042@suswa.mountain/
> Fixes: 1721bc1b2afa ("drm/amdgpu: Update VF2PF interface")
> Cc: Dan Carpenter <dan.carpenter@...aro.org>
> Cc: wenlunpeng <wenlunpeng@...ontech.com>
> Reported-by: Su Hui <suhui@...china.com>
> Signed-off-by: WangYuli <wangyuli@...ontech.com>
> ---
>  drivers/gpu/drm/amd/amdgpu/amdgv_sriovmsg.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgv_sriovmsg.h b/drivers/gpu/drm/amd/amdgpu/amdgv_sriovmsg.h
> index fb2b394bb9c5..6e9eeaeb3de1 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgv_sriovmsg.h
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgv_sriovmsg.h
> @@ -213,7 +213,7 @@ struct amd_sriov_msg_pf2vf_info {
>         uint32_t gpu_capacity;
>         /* reserved */
>         uint32_t reserved[256 - AMD_SRIOV_MSG_PF2VF_INFO_FILLED_SIZE];
> -};
> +} __packed;
>
>  struct amd_sriov_msg_vf2pf_info_header {
>         /* the total structure size in byte */
> @@ -273,7 +273,7 @@ struct amd_sriov_msg_vf2pf_info {
>         uint32_t mes_info_size;
>         /* reserved */
>         uint32_t reserved[256 - AMD_SRIOV_MSG_VF2PF_INFO_FILLED_SIZE];
> -};
> +} __packed;
>
>  /* mailbox message send from guest to host  */
>  enum amd_sriov_mailbox_request_message {
> --
> 2.43.4
>