[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CADnq5_Ouob7zaqF1uTwL70QnWegEpvi0kkJY42yULPfCoW5d_Q@mail.gmail.com>
Date: Mon, 5 Aug 2024 15:52:18 -0400
From: Alex Deucher <alexdeucher@...il.com>
To: Colin Ian King <colin.i.king@...il.com>
Cc: Chaitanya Dhere <chaitanya.dhere@....com>, Jun Lei <jun.lei@....com>,
Harry Wentland <harry.wentland@....com>, Leo Li <sunpeng.li@....com>,
Alex Deucher <alexander.deucher@....com>, Christian König <christian.koenig@....com>,
Xinhui.Pan@....com, David Airlie <airlied@...il.com>, Daniel Vetter <daniel@...ll.ch>,
amd-gfx@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org,
kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH][next] drm/amd/display: remove extraneous ; after statements
Applied. Thanks!
On Fri, Aug 2, 2024 at 8:00 AM Colin Ian King <colin.i.king@...il.com> wrote:
>
> There are a several statements with two following semicolons, replace
> these with just one semicolon.
>
> Signed-off-by: Colin Ian King <colin.i.king@...il.com>
> ---
> .../drm/amd/display/dc/dml2/dml21/dml21_translation_helper.c | 2 +-
> .../dc/dml2/dml21/src/dml2_core/dml2_core_dcn4_calcs.c | 2 +-
> .../display/dc/dml2/dml21/src/dml2_core/dml2_core_shared.c | 4 ++--
> drivers/gpu/drm/amd/display/dc/dml2/dml2_utils.c | 2 +-
> 4 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dml2/dml21/dml21_translation_helper.c b/drivers/gpu/drm/amd/display/dc/dml2/dml21/dml21_translation_helper.c
> index 65776602648d..9956974c4527 100644
> --- a/drivers/gpu/drm/amd/display/dc/dml2/dml21/dml21_translation_helper.c
> +++ b/drivers/gpu/drm/amd/display/dc/dml2/dml21/dml21_translation_helper.c
> @@ -1040,7 +1040,7 @@ void dml21_copy_clocks_to_dc_state(struct dml2_context *in_ctx, struct dc_state
> void dml21_extract_legacy_watermark_set(const struct dc *in_dc, struct dcn_watermarks *watermark, enum dml2_dchub_watermark_reg_set_index reg_set_idx, struct dml2_context *in_ctx)
> {
> struct dml2_core_internal_display_mode_lib *mode_lib = &in_ctx->v21.dml_init.dml2_instance->core_instance.clean_me_up.mode_lib;
> - double refclk_freq_in_mhz = (in_ctx->v21.display_config.overrides.hw.dlg_ref_clk_mhz > 0) ? (double)in_ctx->v21.display_config.overrides.hw.dlg_ref_clk_mhz : mode_lib->soc.dchub_refclk_mhz;;
> + double refclk_freq_in_mhz = (in_ctx->v21.display_config.overrides.hw.dlg_ref_clk_mhz > 0) ? (double)in_ctx->v21.display_config.overrides.hw.dlg_ref_clk_mhz : mode_lib->soc.dchub_refclk_mhz;
>
> if (reg_set_idx >= DML2_DCHUB_WATERMARK_SET_NUM) {
> /* invalid register set index */
> diff --git a/drivers/gpu/drm/amd/display/dc/dml2/dml21/src/dml2_core/dml2_core_dcn4_calcs.c b/drivers/gpu/drm/amd/display/dc/dml2/dml21/src/dml2_core/dml2_core_dcn4_calcs.c
> index 13f2c80bad4c..54197d18ab19 100644
> --- a/drivers/gpu/drm/amd/display/dc/dml2/dml21/src/dml2_core/dml2_core_dcn4_calcs.c
> +++ b/drivers/gpu/drm/amd/display/dc/dml2/dml21/src/dml2_core/dml2_core_dcn4_calcs.c
> @@ -7218,7 +7218,7 @@ static bool dml_core_mode_support(struct dml2_core_calcs_mode_support_ex *in_out
> #if defined(DV_BUILD)
> // Assume a memory config setting of 3 in 420 mode or get a new ip parameter that reflects the programming.
> if (mode_lib->ms.BytePerPixelC[k] != 0.0 && display_cfg->plane_descriptors[k].pixel_format != dml2_rgbe_alpha) {
> - lb_buffer_size_bits_luma = 34620 * 57;;
> + lb_buffer_size_bits_luma = 34620 * 57;
> lb_buffer_size_bits_chroma = 13560 * 57;
> }
> #endif
> diff --git a/drivers/gpu/drm/amd/display/dc/dml2/dml21/src/dml2_core/dml2_core_shared.c b/drivers/gpu/drm/amd/display/dc/dml2/dml21/src/dml2_core/dml2_core_shared.c
> index c54c29711a65..8f3c1c0b1cc1 100644
> --- a/drivers/gpu/drm/amd/display/dc/dml2/dml21/src/dml2_core/dml2_core_shared.c
> +++ b/drivers/gpu/drm/amd/display/dc/dml2/dml21/src/dml2_core/dml2_core_shared.c
> @@ -6464,8 +6464,8 @@ static void CalculateSwathAndDETConfiguration(struct dml2_core_internal_scratch
> p->SwathHeightC[k] = l->MaximumSwathHeightC[k] / 2;
> l->RoundedUpSwathSizeBytesY[k] = p->full_swath_bytes_l[k] / 2;
> l->RoundedUpSwathSizeBytesC[k] = p->full_swath_bytes_c[k] / 2;
> - p->request_size_bytes_luma[k] = ((p->BytePerPixY[k] == 2) == dml_is_vertical_rotation(p->display_cfg->plane_descriptors[k].composition.rotation_angle)) ? 128 : 64;;
> - p->request_size_bytes_chroma[k] = ((p->BytePerPixC[k] == 2) == dml_is_vertical_rotation(p->display_cfg->plane_descriptors[k].composition.rotation_angle)) ? 128 : 64;;
> + p->request_size_bytes_luma[k] = ((p->BytePerPixY[k] == 2) == dml_is_vertical_rotation(p->display_cfg->plane_descriptors[k].composition.rotation_angle)) ? 128 : 64;
> + p->request_size_bytes_chroma[k] = ((p->BytePerPixC[k] == 2) == dml_is_vertical_rotation(p->display_cfg->plane_descriptors[k].composition.rotation_angle)) ? 128 : 64;
> }
>
> if (p->SwathHeightC[k] == 0)
> diff --git a/drivers/gpu/drm/amd/display/dc/dml2/dml2_utils.c b/drivers/gpu/drm/amd/display/dc/dml2/dml2_utils.c
> index 7655501e75d4..9e8ff3a9718e 100644
> --- a/drivers/gpu/drm/amd/display/dc/dml2/dml2_utils.c
> +++ b/drivers/gpu/drm/amd/display/dc/dml2/dml2_utils.c
> @@ -421,7 +421,7 @@ unsigned int dml2_calc_max_scaled_time(
>
> void dml2_extract_writeback_wm(struct dc_state *context, struct display_mode_lib_st *dml_core_ctx)
> {
> - int i, j = 0;;
> + int i, j = 0;
> struct mcif_arb_params *wb_arb_params = NULL;
> struct dcn_bw_writeback *bw_writeback = NULL;
> enum mmhubbub_wbif_mode wbif_mode = PACKED_444_FP16; /*for now*/
> --
> 2.39.2
>
Powered by blists - more mailing lists