linux-kernel - Re: [PATCH] perf pmus: Fix duplicate events caused segfault

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZrEzl-QftBU2cNK0@x1>
Date: Mon, 5 Aug 2024 17:18:31 -0300
From: Arnaldo Carvalho de Melo <acme@...nel.org>
To: Ian Rogers <irogers@...gle.com>
Cc: Athira Rajeev <atrajeev@...ux.vnet.ibm.com>,
	Eric Lin <eric.lin@...ive.com>, Namhyung Kim <namhyung@...nel.org>,
	Peter Zijlstra <peterz@...radead.org>,
	Ingo Molnar <mingo@...hat.com>, Mark Rutland <mark.rutland@....com>,
	Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
	Jiri Olsa <jolsa@...nel.org>,
	Adrian Hunter <adrian.hunter@...el.com>,
	Kan Liang <kan.liang@...ux.intel.com>,
	James Clark <james.clark@....com>,
	linux-perf-users <linux-perf-users@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>, vincent.chen@...ive.com,
	greentime.hu@...ive.com, Samuel Holland <samuel.holland@...ive.com>
Subject: Re: [PATCH] perf pmus: Fix duplicate events caused segfault

On Mon, Aug 05, 2024 at 12:48:23PM -0700, Ian Rogers wrote:
> On Mon, Aug 5, 2024 at 10:02 AM Ian Rogers <irogers@...gle.com> wrote:
> > On Mon, Aug 5, 2024 at 7:24 AM Athira Rajeev <atrajeev@...ux.vnet.ibm.com> wrote:
> > > > On 4 Aug 2024, at 8:36 PM, Eric Lin <eric.lin@...ive.com> wrote:
> > > > On Sun, Jul 21, 2024 at 11:44 PM Eric Lin <eric.lin@...ive.com> wrote:
> > > > Kindly ping.

> > > > Can I ask, are there any more comments about this patch? Thanks.

> > > The functions there says alias and to skip duplicate alias. I am not sure if that is for events

> > Fwiw, I'm trying to get rid of the term alias it should mean event.
> > For some reason the code always referred to events as aliases as
> > exemplified by:
> > https://git.kernel.org/pub/scm/linux/kernel/git/perf/perf-tools-next.git/tree/tools/perf/util/pmu.c?h=tmp.perf-tools-next#n55
> > But it is possible to have an "alias" (different) name for a PMU and
> > I'm sure for other things too. So the term alias is ambiguous and
> > these things are events, so let's just call them events to be most
> > intention revealing.

> > > Namhyung, Ian, Arnaldo
> > > Any comments here ?

> > I'll take a look.
> 
> The problematic events all come from copy pasting ArchStdEvent. It
> feels better to have an invariant that events appear once so I sent
> out a series to clean this up:
> https://lore.kernel.org/linux-perf-users/20240805194424.597244-1-irogers@google.com/
> If you could test and add a tested-by tag that'd be great!

I have the series in tmp.perf-tools-next, will collect
Tested-by/Reviewed-by if they are provided, before moving it to
perf-tools-next.

- Arnaldo