linux-kernel - Re: [PATCH v3 25/26] mm: make range-to-target_node lookup facility a part of numa

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <66b13512a0fd3_c144829488@dwillia2-xfh.jf.intel.com.notmuch>
Date: Mon, 5 Aug 2024 13:24:50 -0700
From: Dan Williams <dan.j.williams@...el.com>
To: Mike Rapoport <rppt@...nel.org>, <linux-kernel@...r.kernel.org>
CC: Alexander Gordeev <agordeev@...ux.ibm.com>, Andreas Larsson
	<andreas@...sler.com>, Andrew Morton <akpm@...ux-foundation.org>, "Arnd
 Bergmann" <arnd@...db.de>, Borislav Petkov <bp@...en8.de>, Catalin Marinas
	<catalin.marinas@....com>, Christophe Leroy <christophe.leroy@...roup.eu>,
	Dan Williams <dan.j.williams@...el.com>, Dave Hansen
	<dave.hansen@...ux.intel.com>, David Hildenbrand <david@...hat.com>, "David
 S. Miller" <davem@...emloft.net>, Davidlohr Bueso <dave@...olabs.net>, "Greg
 Kroah-Hartman" <gregkh@...uxfoundation.org>, Heiko Carstens
	<hca@...ux.ibm.com>, Huacai Chen <chenhuacai@...nel.org>, Ingo Molnar
	<mingo@...hat.com>, Jiaxun Yang <jiaxun.yang@...goat.com>, "John Paul Adrian
 Glaubitz" <glaubitz@...sik.fu-berlin.de>, Jonathan Cameron
	<jonathan.cameron@...wei.com>, Jonathan Corbet <corbet@....net>, "Michael
 Ellerman" <mpe@...erman.id.au>, Mike Rapoport <rppt@...nel.org>, "Palmer
 Dabbelt" <palmer@...belt.com>, "Rafael J. Wysocki" <rafael@...nel.org>, "Rob
 Herring" <robh@...nel.org>, Samuel Holland <samuel.holland@...ive.com>,
	Thomas Bogendoerfer <tsbogend@...ha.franken.de>, Thomas Gleixner
	<tglx@...utronix.de>, Vasily Gorbik <gor@...ux.ibm.com>, Will Deacon
	<will@...nel.org>, Zi Yan <ziy@...dia.com>, <devicetree@...r.kernel.org>,
	<linux-acpi@...r.kernel.org>, <linux-arch@...r.kernel.org>,
	<linux-arm-kernel@...ts.infradead.org>, <linux-cxl@...r.kernel.org>,
	<linux-doc@...r.kernel.org>, <linux-mips@...r.kernel.org>,
	<linux-mm@...ck.org>, <linux-riscv@...ts.infradead.org>,
	<linux-s390@...r.kernel.org>, <linux-sh@...r.kernel.org>,
	<linuxppc-dev@...ts.ozlabs.org>, <loongarch@...ts.linux.dev>,
	<nvdimm@...ts.linux.dev>, <sparclinux@...r.kernel.org>, <x86@...nel.org>
Subject: Re: [PATCH v3 25/26] mm: make range-to-target_node lookup facility a
 part of numa_memblks

Mike Rapoport wrote:
> From: "Mike Rapoport (Microsoft)" <rppt@...nel.org>
> 
> The x86 implementation of range-to-target_node lookup (i.e.
> phys_to_target_node() and memory_add_physaddr_to_nid()) relies on
> numa_memblks.
> 
> Since numa_memblks are now part of the generic code, move these
> functions from x86 to mm/numa_memblks.c and select
> CONFIG_NUMA_KEEP_MEMINFO when CONFIG_NUMA_MEMBLKS=y for dax and cxl.
> 
> Signed-off-by: Mike Rapoport (Microsoft) <rppt@...nel.org>
> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@...wei.com>
> Tested-by: Zi Yan <ziy@...dia.com> # for x86_64 and arm64

Looks good to me:

Reviewed-by: Dan Williams <dan.j.williams@...el.com>