linux-kernel - Re: [PATCH] workqueue: Correct declaration of cpu_pwq in struct workqueue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZrE2rpXmGQ-P4kYE@slm.duckdns.org>
Date: Mon, 5 Aug 2024 10:31:42 -1000
From: Tejun Heo <tj@...nel.org>
To: Uros Bizjak <ubizjak@...il.com>
Cc: linux-kernel@...r.kernel.org, Lai Jiangshan <jiangshanlai@...il.com>
Subject: Re: [PATCH] workqueue: Correct declaration of cpu_pwq in struct
 workqueue_struct

On Mon, Aug 05, 2024 at 09:30:29AM +0200, Uros Bizjak wrote:
> cpu_pwq is used in various percpu functions that expect variable in
> __percpu address space. Correct the declaration of cpu_pwq to
> 
> struct pool_workqueue __rcu * __percpu *cpu_pwq
> 
> to declare the variable as __percpu pointer.
> 
> The patch also fixes following sparse errors:
> 
> workqueue.c:380:37: warning: duplicate [noderef]
> workqueue.c:380:37: error: multiple address spaces given: __rcu & __percpu
> workqueue.c:2271:15: error: incompatible types in comparison expression (different address spaces):
> workqueue.c:2271:15:    struct pool_workqueue [noderef] __rcu *
> workqueue.c:2271:15:    struct pool_workqueue [noderef] __percpu *
> 
> and uncovers a couple of exisiting "incorrect type in assignment"
> warnings (from __rcu address space), which this patch does not address.
> 
> Found by GCC's named address space checks.
> 
> There were no changes in the resulting object files.
> 
> Signed-off-by: Uros Bizjak <ubizjak@...il.com>
> Cc: Tejun Heo <tj@...nel.org>
> Cc: Lai Jiangshan <jiangshanlai@...il.com>

Applied to wq/for-6.11-fixes.

Thanks.

-- 
tejun