linux-kernel - Re: [PATCH v11 2/2] dmaengine: Loongson1: Add Loongson-1 APB DMA driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202408051242.8kGK28W7-lkp@intel.com>
Date: Mon, 5 Aug 2024 12:58:49 +0800
From: kernel test robot <lkp@...el.com>
To: Keguang Zhang via B4 Relay <devnull+keguang.zhang.gmail.com@...nel.org>,
	Keguang Zhang <keguang.zhang@...il.com>,
	Vinod Koul <vkoul@...nel.org>, Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>
Cc: oe-kbuild-all@...ts.linux.dev, linux-mips@...r.kernel.org,
	dmaengine@...r.kernel.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org, Jiaxun Yang <jiaxun.yang@...goat.com>
Subject: Re: [PATCH v11 2/2] dmaengine: Loongson1: Add Loongson-1 APB DMA
 driver

Hi Keguang,

kernel test robot noticed the following build warnings:

[auto build test WARNING on 048d8cb65cde9fe7534eb4440bcfddcf406bb49c]

url:    https://github.com/intel-lab-lkp/linux/commits/Keguang-Zhang-via-B4-Relay/dt-bindings-dma-Add-Loongson-1-APB-DMA/20240803-111220
base:   048d8cb65cde9fe7534eb4440bcfddcf406bb49c
patch link:    https://lore.kernel.org/r/20240802-loongson1-dma-v11-2-85392357d4e0%40gmail.com
patch subject: [PATCH v11 2/2] dmaengine: Loongson1: Add Loongson-1 APB DMA driver
config: sparc64-randconfig-r063-20240804 (https://download.01.org/0day-ci/archive/20240805/202408051242.8kGK28W7-lkp@intel.com/config)
compiler: sparc64-linux-gcc (GCC) 14.1.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240805/202408051242.8kGK28W7-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202408051242.8kGK28W7-lkp@intel.com/

All warnings (new ones prefixed by >>):

   drivers/dma/loongson1-apb-dma.c: In function 'ls1x_dma_chan_probe':
>> drivers/dma/loongson1-apb-dma.c:520:34: warning: '%u' directive writing between 1 and 10 bytes into a region of size 2 [-Wformat-overflow=]
     520 |         sprintf(pdev_irqname, "ch%u", chan_id);
         |                                  ^~
   drivers/dma/loongson1-apb-dma.c:520:31: note: directive argument in the range [0, 2147483646]
     520 |         sprintf(pdev_irqname, "ch%u", chan_id);
         |                               ^~~~~~
   drivers/dma/loongson1-apb-dma.c:520:9: note: 'sprintf' output between 4 and 13 bytes into a destination of size 4
     520 |         sprintf(pdev_irqname, "ch%u", chan_id);
         |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~


vim +520 drivers/dma/loongson1-apb-dma.c

   510	
   511	static int ls1x_dma_chan_probe(struct platform_device *pdev,
   512				       struct ls1x_dma *dma, int chan_id)
   513	{
   514		struct device *dev = &pdev->dev;
   515		struct ls1x_dma_chan *chan = &dma->chan[chan_id];
   516		char pdev_irqname[4];
   517		char *irqname;
   518		int ret;
   519	
 > 520		sprintf(pdev_irqname, "ch%u", chan_id);
   521		chan->irq = platform_get_irq_byname(pdev, pdev_irqname);
   522		if (chan->irq < 0)
   523			return -ENODEV;
   524	
   525		irqname = devm_kasprintf(dev, GFP_KERNEL, "%s:%s",
   526					 dev_name(dev), pdev_irqname);
   527		if (!irqname)
   528			return -ENOMEM;
   529	
   530		ret = devm_request_irq(dev, chan->irq, ls1x_dma_irq_handler,
   531				       IRQF_SHARED, irqname, chan);
   532		if (ret)
   533			return dev_err_probe(dev, ret, "failed to request IRQ %u\n",
   534					     chan->irq);
   535	
   536		chan->reg_base = dma->reg_base;
   537		chan->vchan.desc_free = ls1x_dma_free_desc;
   538		vchan_init(&chan->vchan, &dma->ddev);
   539		dev_info(dev, "%s (irq %d) initialized\n", pdev_irqname, chan->irq);
   540	
   541		return 0;
   542	}
   543	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki