linux-kernel - Re: [PATCH v4] usb: gadget: f_fs: add capability for dfu run-time descriptor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAB0kiBLrZ+t8voXNGkDudG+vy4i3pOP77Pn9ytrprii6OPXjFQ@mail.gmail.com>
Date: Mon, 5 Aug 2024 19:39:19 -0400
From: Chris Wulff <crwulff@...il.com>
To: Matthew Wilcox <willy@...radead.org>
Cc: linux-usb@...r.kernel.org, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, 
	Jonathan Corbet <corbet@....net>, Paul Cercueil <paul@...pouillou.net>, 
	Christian Brauner <brauner@...nel.org>, Eric Farman <farman@...ux.ibm.com>, 
	Wesley Cheng <quic_wcheng@...cinc.com>, Dmitry Antipov <dmantipov@...dex.ru>, 
	Jeff Layton <jlayton@...nel.org>, linux-doc@...r.kernel.org, 
	linux-kernel@...r.kernel.org, David Sands <david.sands@...mp.com>
Subject: Re: [PATCH v4] usb: gadget: f_fs: add capability for dfu run-time descriptor

On Sun, Aug 4, 2024 at 11:39 PM Matthew Wilcox <willy@...radead.org> wrote:
>
> On Sun, Aug 04, 2024 at 08:06:40PM -0400, crwulff@...il.com wrote:
> > diff --git a/include/uapi/linux/usb/ch9.h b/include/uapi/linux/usb/ch9.h
> > index 44d73ba8788d..91f0f7e214a5 100644
> > --- a/include/uapi/linux/usb/ch9.h
> > +++ b/include/uapi/linux/usb/ch9.h
> > @@ -254,6 +254,9 @@ struct usb_ctrlrequest {
> >  #define USB_DT_DEVICE_CAPABILITY     0x10
> >  #define USB_DT_WIRELESS_ENDPOINT_COMP        0x11
> >  #define USB_DT_WIRE_ADAPTER          0x21
> > +/* From USB Device Firmware Upgrade Specification, Revision 1.1 */
> > +#define USB_DT_DFU_FUNCTIONAL                0x21
>
> This is the only place in the entire patch where you explain what "DFU"
> means.  Is this really such a well-known acronym that it doesn't need to
> be in the documentation or the commit message?

Yeah, it would probably be good to add that to the documentation. I'll
add that info.

(It stands for "Device Firmware Upgrade")

  -- Chris Wulff