linux-kernel - Re: [PATCH] mm/z3fold: Add __percpu annotation to *unbuddied pointer in struct z3fold

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <607b6854-081d-7d07-b2a8-fbfb004d5723@huawei.com>
Date: Mon, 5 Aug 2024 15:09:58 +0800
From: Miaohe Lin <linmiaohe@...wei.com>
To: Uros Bizjak <ubizjak@...il.com>, <linux-mm@...ck.org>,
	<linux-kernel@...r.kernel.org>
CC: Vitaly Wool <vitaly.wool@...sulko.com>, Andrew Morton
	<akpm@...ux-foundation.org>
Subject: Re: [PATCH] mm/z3fold: Add __percpu annotation to *unbuddied pointer
 in struct z3fold_pool

On 2024/7/30 20:34, Uros Bizjak wrote:
> Compiling z3fold.c results in several sparse warnings:
> 
> z3fold.c:797:21: warning: incorrect type in initializer (different address spaces)
> z3fold.c:797:21:    expected void const [noderef] __percpu *__vpp_verify
> z3fold.c:797:21:    got struct list_head *
> z3fold.c:852:37: warning: incorrect type in initializer (different address spaces)
> z3fold.c:852:37:    expected void const [noderef] __percpu *__vpp_verify
> z3fold.c:852:37:    got struct list_head *
> z3fold.c:924:25: warning: incorrect type in assignment (different address spaces)
> z3fold.c:924:25:    expected struct list_head *unbuddied
> z3fold.c:924:25:    got void [noderef] __percpu *_res
> z3fold.c:930:33: warning: incorrect type in initializer (different address spaces)
> z3fold.c:930:33:    expected void const [noderef] __percpu *__vpp_verify
> z3fold.c:930:33:    got struct list_head *
> z3fold.c:949:25: warning: incorrect type in argument 1 (different address spaces)
> z3fold.c:949:25:    expected void [noderef] __percpu *__pdata
> z3fold.c:949:25:    got struct list_head *unbuddied
> z3fold.c:979:25: warning: incorrect type in argument 1 (different address spaces)
> z3fold.c:979:25:    expected void [noderef] __percpu *__pdata
> z3fold.c:979:25:    got struct list_head *unbuddied
> 
> Add __percpu annotation to *unbuddied pointer to fix these warnings.
> 
> Signed-off-by: Uros Bizjak <ubizjak@...il.com>
> Cc: Vitaly Wool <vitaly.wool@...sulko.com>
> Cc: Miaohe Lin <linmiaohe@...wei.com>
> Cc: Andrew Morton <akpm@...ux-foundation.org>

Reviewed-by: Miaohe Lin <linmiaohe@...wei.com>
Thanks.
.