linux-kernel - Re: [PATCH v2 1/1] drm/fb-helper: Don't schedule_work() to flush frame buffer during panic()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c349e2c6-027e-4e65-800e-f30ac0a0a785@suse.de>
Date: Mon, 5 Aug 2024 09:31:00 +0200
From: Thomas Zimmermann <tzimmermann@...e.de>
To: Qiuxu Zhuo <qiuxu.zhuo@...el.com>, maarten.lankhorst@...ux.intel.com,
 mripard@...nel.org, airlied@...il.com, daniel@...ll.ch
Cc: dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
 tony.luck@...el.com, yudong.wang@...el.com
Subject: Re: [PATCH v2 1/1] drm/fb-helper: Don't schedule_work() to flush
 frame buffer during panic()

Hi

Am 05.08.24 um 09:13 schrieb Qiuxu Zhuo:
>> From: Qiuxu Zhuo <qiuxu.zhuo@...el.com>
>> To: maarten.lankhorst@...ux.intel.com, mripard@...nel.org,
>> 	tzimmermann@...e.de, airlied@...il.com, daniel@...ll.ch
>> Cc: dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
>> 	tony.luck@...el.com, qiuxu.zhuo@...el.com, yudong.wang@...el.com
>> Subject: [PATCH v2 1/1] drm/fb-helper: Don't schedule_work() to flush frame buffer during panic()
>> [...]
>> Acked-by: Thomas Zimmermann <tzimmermann@...e.de>
>> Reported-by: Yudong Wang <yudong.wang@...el.com>
>> Tested-by: Yudong Wang <yudong.wang@...el.com>
>> Signed-off-by: Qiuxu Zhuo <qiuxu.zhuo@...el.com>
> Hi Maarten and maintainers,
>
> A gentle ping :-).
>
> Could you please help push this v2 fix upstream?
> If you have any concerns, please let me know.

I already acked this patch, but I still have a question: during a panic, 
will fbcon still print a panic message? I think that would likely 
require scheduling that worker.

Best regards
Thomas

>
> Thanks!
> -Qiuxu

-- 
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)