linux-kernel - Re: [PATCH v2] Makefile: add $(srctree) to dependency of compile

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAAVeFuJ8ruqSGbqLTG3d31tTy6p22af7yt6C59mYhS2p0goa-Q@mail.gmail.com>
Date: Mon, 5 Aug 2024 16:33:49 +0900
From: Alexandre Courbot <gnurou@...il.com>
To: Masahiro Yamada <masahiroy@...nel.org>
Cc: Nathan Chancellor <nathan@...nel.org>, Nicolas Schier <nicolas@...sle.eu>, linux-kbuild@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] Makefile: add $(srctree) to dependency of
 compile_commands.json target

On Mon, Aug 5, 2024 at 3:20 PM Masahiro Yamada <masahiroy@...nel.org> wrote:
>
> On Sun, Aug 4, 2024 at 2:51 PM Alexandre Courbot <gnurou@...il.com> wrote:
> >
> > When trying to build the compile_commands.json target from an external
> > module's directory, the following error is displayed:
>
>
> As I mentioned in v1, this issue only happens when using the kernel
> directory built in a separate output directory (O=).
>
> Unless you have a opposition, I will reword this sentence as follows:
>
> When trying to build compile_commands.json for an external module
> against the kernel built in a separate output directory, the following
> error is displayed:

Sounds perfect! Thank you.
Alex.

>
>
>
>
>
>
> >
> >         make[1]: *** No rule to make target 'scripts/clang-tools/gen_compile_commands.py',
> >         needed by 'compile_commands.json'. Stop.
> >
> > This is because gen_compile_commands.py was previously looked up using a
> > relative path to $(srctree), but commit b1992c3772e6 ("kbuild: use
> > $(src) instead of $(srctree)/$(src) for source directory") stopped
> > defining VPATH for external module builds.
> >
> > Prefixing gen_compile_commands.py with $(srctree) fixes the problem.
> >
> > Fixes: b1992c3772e6 ("kbuild: use $(src) instead of $(srctree)/$(src) for source directory")
> > Signed-off-by: Alexandre Courbot <gnurou@...il.com>
> > ---
> >  Makefile | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/Makefile b/Makefile
> > index 8ad55d6e7b60..52d7dfe4212a 100644
> > --- a/Makefile
> > +++ b/Makefile
> > @@ -1980,7 +1980,7 @@ nsdeps: modules
> >  quiet_cmd_gen_compile_commands = GEN     $@
> >        cmd_gen_compile_commands = $(PYTHON3) $< -a $(AR) -o $@ $(filter-out $<, $(real-prereqs))
> >
> > -$(extmod_prefix)compile_commands.json: scripts/clang-tools/gen_compile_commands.py \
> > +$(extmod_prefix)compile_commands.json: $(srctree)/scripts/clang-tools/gen_compile_commands.py \
> >         $(if $(KBUILD_EXTMOD),, vmlinux.a $(KBUILD_VMLINUX_LIBS)) \
> >         $(if $(CONFIG_MODULES), $(MODORDER)) FORCE
> >         $(call if_changed,gen_compile_commands)
> > --
> > 2.46.0
> >
> >
>
>
> --
> Best Regards
> Masahiro Yamada