linux-kernel - Re: [PATCH v3 1/3] wifi: mwifiex: simplify WPA flags setting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZrCBGA29KbqkTgJU@pengutronix.de>
Date: Mon, 5 Aug 2024 09:36:56 +0200
From: Sascha Hauer <s.hauer@...gutronix.de>
To: Kalle Valo <kvalo@...nel.org>
Cc: Brian Norris <briannorris@...omium.org>,
	Francesco Dolcini <francesco@...cini.it>,
	David Lin <yu-hao.lin@....com>, linux-wireless@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Francesco Dolcini <francesco.dolcini@...adex.com>
Subject: Re: [PATCH v3 1/3] wifi: mwifiex: simplify WPA flags setting

On Sun, Aug 04, 2024 at 08:57:54AM +0000, Kalle Valo wrote:
> Sascha Hauer <s.hauer@...gutronix.de> wrote:
> 
> > The WPA flags setting only depends on the wpa_versions bitfield and not
> > on the AKM suite, so move it out of the switch/case to simplify the code
> > a bit. Also set bss_config->protocol to zero explicitly. This is done
> > only to make the code clearer, bss_config has been zero alloced by the
> > caller, so should be zero already. No functional change intended.
> > 
> > Reviewed-by: Francesco Dolcini <francesco.dolcini@...adex.com>
> > Acked-by: Brian Norris <briannorris@...omium.org>
> > Signed-off-by: Sascha Hauer <s.hauer@...gutronix.de>
> 
> There were conflicts on wireless-next, please rebase.

Thanks for noting. Just sent out a v4.

I realized the host-mlme patches are merged in wireless-next. I had them
in my tree anyway already, so the necessary changes looked all familiar.

Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |