linux-kernel - Re: [PATCH v3] ALSA: hda: cs35l56: Stop creating ALSA controls for firmware coefficients

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <878qxbl88p.wl-tiwai@suse.de>
Date: Mon, 05 Aug 2024 09:49:26 +0200
From: Takashi Iwai <tiwai@...e.de>
To: Simon Trimmer <simont@...nsource.cirrus.com>
Cc: <tiwai@...e.com>,
	<linux-sound@...r.kernel.org>,
	<alsa-devel@...a-project.org>,
	<linux-kernel@...r.kernel.org>,
	<patches@...nsource.cirrus.com>
Subject: Re: [PATCH v3] ALSA: hda: cs35l56: Stop creating ALSA controls for firmware coefficients

On Thu, 01 Aug 2024 16:31:39 +0200,
Simon Trimmer wrote:
> 
> A number of laptops have gone to market with old firmware versions that
> export controls that have since been hidden, but we can't just install a
> newer firmware because the firmware for each product is customized and
> qualified by the OEM. The issue is that alsactl save and restore has no
> idea what controls are good to persist which can lead to
> misconfiguration.
> 
> There is no reason that the UCM or user should need to interact with any
> of the ALSA controls for the firmware coefficients so they can be
> removed entirely, this also simplifies the driver.
> 
> Signed-off-by: Simon Trimmer <simont@...nsource.cirrus.com>
> ---
> Changes in v3:
> - Remove ability to add firmware coefficients as ALSA controls
>   entirely
> 
> Changes in v2:
> - v1 was accidentally the backport version for older kernels instead of
>   the one for v6.11

Applied now to for-linus branch.  Thanks.


Takashi