linux-kernel - Re: [PATCH v3 3/3] ARM: Use generic interface to simplify crashkernel reservation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdaJLBt8-c_f4Q3_nLdB_7hZE9Pv5LiX0ObiycXZcj9j0g@mail.gmail.com>
Date: Mon, 5 Aug 2024 09:51:56 +0200
From: Linus Walleij <linus.walleij@...aro.org>
To: Jinjie Ruan <ruanjinjie@...wei.com>
Cc: linux@...linux.org.uk, catalin.marinas@....com, will@...nel.org, 
	paul.walmsley@...ive.com, palmer@...belt.com, aou@...s.berkeley.edu, 
	tglx@...utronix.de, mingo@...hat.com, bp@...en8.de, 
	dave.hansen@...ux.intel.com, hpa@...or.com, bhe@...hat.com, vgoyal@...hat.com, 
	dyoung@...hat.com, arnd@...db.de, afd@...com, akpm@...ux-foundation.org, 
	eric.devolder@...cle.com, gregkh@...uxfoundation.org, javierm@...hat.com, 
	deller@....de, robh@...nel.org, hbathini@...ux.ibm.com, 
	thunder.leizhen@...wei.com, chenjiahao16@...wei.com, 
	linux-kernel@...r.kernel.org, kexec@...ts.infradead.org, 
	linux-arm-kernel@...ts.infradead.org, linux-riscv@...ts.infradead.org
Subject: Re: [PATCH v3 3/3] ARM: Use generic interface to simplify crashkernel reservation

On Thu, Jul 18, 2024 at 5:51 AM Jinjie Ruan <ruanjinjie@...wei.com> wrote:

> Currently, x86, arm64, riscv and loongarch has been switched to generic
> crashkernel reservation, which is also ready for 32bit system.
> So with the help of function parse_crashkernel() and generic
> reserve_crashkernel_generic(), arm32 crashkernel reservation can also
> be simplified by steps:
>
> 1) Add a new header file <asm/crash_reserve.h>, and define CRASH_ALIGN,
>    CRASH_ADDR_LOW_MAX, CRASH_ADDR_HIGH_MAX in it;
>
> 2) Add arch_reserve_crashkernel() to call parse_crashkernel() and
>    reserve_crashkernel_generic();
>
> 3) Add ARCH_HAS_GENERIC_CRASHKERNEL_RESERVATION Kconfig in
>    arch/arm/Kconfig.
>
> The old reserve_crashkernel() can be removed.
>
> Following test cases have been performed as expected on QEMU vexpress-a9
> (1GB system memory):
>
> 1) crashkernel=4G,high                          // invalid
> 2) crashkernel=1G,high                          // invalid
> 3) crashkernel=1G,high crashkernel=0M,low       // invalid
> 4) crashkernel=256M,high                        // invalid
> 5) crashkernel=256M,low                         // invalid
> 6) crashkernel=256M crashkernel=256M,high       // high is ignored, ok
> 7) crashkernel=256M crashkernel=256M,low        // low is ignored, ok
> 8) crashkernel=256M,high crashkernel=256M,low   // invalid
> 9) crashkernel=256M,high crashkernel=4G,low     // invalid
> 10) crashkernel=256M                            // ok
> 11) crashkernel=512M                            // ok
> 12) crashkernel=256M@...8000000                 // ok
> 13) crashkernel=256M@...8000000                 // ok
> 14) crashkernel=512M@...8000000                 // ok
>
> Signed-off-by: Jinjie Ruan <ruanjinjie@...wei.com>
> Tested-by: Jinjie Ruan <ruanjinjie@...wei.com>
> ---
> v3:
> - Update the commit message.

I haven't used crash much but it looks right to my untrained eye.
Acked-by: Linus Walleij <linus.walleij@...aro.org>

Yours,
Linus Walleij